Closed jaymanmdev closed 1 year ago
@jaymanmdev seems like the test suite failed because of the changes you made. Please read the test file and try to fix the issue.
Other than that, I like the idea behind this pr! :)
Sorry, this is my first ever PR in any repo so I am still getting the hang of it, I'm getting in the habit of running the tests before submitting an adjustment to my PR/s from now on. Thanks!
Edit: I can merge the two render tests together later on if that would be preferred. :)
Our contributing guidelines are really basic but that's the one thing that's included in them. 😅
Our contributing guidelines are really basic but that's the one thing that's included in them. 😅
Ah, I didn't pick up on that guidelines file - my bad! I tested the suite this time though.
Just make a sub-test, e.g.
Deno.test('something', async (t) => {
await t.step('first step', async () => {
// some code
})
})
Just make a sub-test, e.g.
Deno.test('something', async (t) => { await t.step('first step', async () => { // some code }) })
I'll quickly do this now, and submit an adjustment.
b1341059dd16ef47954ad1c94e865c41c836a73e
Let me know what you think.
update the JSX render class to not explicitly inject HTML inside of the body tag, allowing for head meta tags and such to be injected and handled by the browser.