Batch request size is zero on retry.

bozaro / git-lfs-migrate

Simple project for convert old repository for using git-lfs feature

MIT License

222 stars 29 forks source link

Batch request size is zero on retry. #14

Closed sgoo closed 8 years ago

sgoo commented 8 years ago

If the initial conversion fails and a retry is attempted, the requests are all made with a "size": 0

This seems to be because data is saved into git-lfs-migrate.mapdb. When that data is reused in git.lfs.migrate.GitConverter#createRemoteFile the main body of that function is skipped so the size never gets set to anything other than zero.

Bitbucket.org's implementation of LFS asserts that the uploaded file matches in both OID and size.

robinst commented 8 years ago

I'm looking into this, looks like the cache will need to be changed.

robinst commented 8 years ago

PR for fix: https://github.com/bozaro/git-lfs-migrate/pull/16

bozaro commented 8 years ago

Fixed by PR #16