bozbez / win-capture-audio

An OBS plugin that allows capture of independant application audio streams on Windows, in a similar fashion to OBS's game capture and Discord's application streaming.
GNU General Public License v2.0
3.79k stars 207 forks source link

[Discussion] Future of this plugin(OBS 28.0 includes app audio capture) #208

Closed pcislocked closed 1 year ago

pcislocked commented 2 years ago

The upcoming OBS release 28 includes application audio capture natively. I'm not sure if it's this plugin embedded into the main release or another implemention, either way it seems unclear what's going to happen to this repo. Just curious and wanted to ask everyone

TheGinGear commented 2 years ago

Personally, I will still be using this until OBS functions EXACTLY like this; with the ability to group a bunch of programs into one volume slider/output. It's a huge convenience not having a bajillion audio sources/sliders sometimes. A different plugin being able to do sort of the same thing would make this redundant then, but for now being able to continue using my setup without having to remake it into a bunch of tiny separate ones would be nice.

RandomNerd1 commented 2 years ago

Personally, I will still be using this until OBS functions EXACTLY like this; with the ability to group a bunch of programs into one volume slider/output. It's a huge convenience not having a bajillion audio sources/sliders sometimes. A different plugin being able to do sort of the same thing would make this redundant then, but for now being able to continue using my setup without having to remake it into a bunch of tiny separate ones would be nice.

Are you using this plugin in OBS 28 presently? I'm afraid to update to the new version without being absolutely certain this plugin will continue to work, as it has been game-changing for me as a streamer, and I am NOT willing to do without it, lol

selvex commented 2 years ago

Same! Reluctant to update cause setting audio sources up was a lot of work, and will be again.

selvex commented 2 years ago

Just found this: https://obsproject.com/kb/obs-studio-28-plugin-compatibility According to OBS, should work.

RandomNerd1 commented 2 years ago

Can someone confirm definitively who's upgraded, or can we get official word from the plugin author? :D

aquazor commented 2 years ago

Can someone confirm definitively who's upgraded, or can we get official word from the plugin author? :D

I installed the newest OBS 28.0.1 and there is no built-in application audio capture thing. Also tried to install the plugin but it doesn't work either...

TheGinGear commented 2 years ago

@RandomNerd1 I can confirm it works just fine, using the latest version of OBS on windows 11. @aquazor that sounds like it's a your setup specific issue, try making sure all your audio devices, channels, and monitor devices are set correctly, both in windows settings, OBS settings, and OBS Advanced Audio Properties.

aquazor commented 2 years ago

@TheGinGear

I decided to check if my windows 10 version matches the requirements and found out that it doesn't. Gotta update it :/ Thanks for the tip

ghost commented 2 years ago

There's a few things to unpack here...

I can't actually figure out how GinGear has done that using this plugin but I don't think that matters for this discussion :-)

Meanwhile - this plugin is still working just fine on OBS 28.0.1, even though it's the latest Windows 11 Insider build, I have VB-cable installed, and I have load of other junk related to Cakewalk by Bandlabs installed.

bozbez commented 2 years ago

Does the new OBS native approach use the same API?

Yes, it's basically a remix of the v2.1.0 version of this plugin integrated into win-wasapi.

I can't actually figure out how GinGear has done that using this plugin but I don't think that matters for this discussion :-)

Just add multiple executables to the input list and they will be mixed internally by the plugin and volume controlled using the single source volume slider.

... capture all audio except the nominated application window

The API itself actually has a switch for exclude mode, but this doesn't work if you want to exclude multiple. The plugin re-implements this using its internal mixing so it does support exclude multiple.

... choosing the target window by using a hotkey

This is super easy to implement and I can't believe they didn't bother including it for 28.0.

I don't know if this plugin consumes QT5 directly anywhere or uses an OBS wrap ...

It uses the OBS plugin properties window API wrap, it isn't linked directly against QT at all.

The problem with the new support in win-wasapi is that it ignores the developments I've had to do to force this plugin to work with the audio session API rather than using window enumeration, and is written in a way that pretty much prohibits them from replicating that without great effort.

This means that it is pretty much bound to always use window enumeration selection and the many drawbacks that brings. This is pretty annoying for everyone since I can't just deprecate this plugin as I'd like and leaves users deciding whether they can get away with using the built in support or having to install a third-party plugin.

As for why this plugin hasn't just been merged into OBS, or why I wasn't consulted on any of the developments or issues with the API is a question you must ask to the OBS maintainers.

ghost commented 2 years ago

Great reply, thank you! (And great plug-in, obviously. I agree it's pretty grim that nobody approached you. It is supposed to be the open-source community after all.)

So the short answer to OP is:

And could I make a request for the backlog - improve the discoverability of that feature which allows you to add multiples to one mixer?

selvex commented 2 years ago

Upgraded to 28 days ago and works flawlessly if anyone is still waiting for confirmation on that.

FeedTheChunk commented 2 years ago

I tried on V 28 yesterday and it did not work. OBS through an error and said that it had to be removed. I downgraded OBS V27 and it seems to work as expected.

Ufinexa commented 2 years ago

Attempted to use this plugin on my friends OBS 28, and it intermittently crashed (one crash for every 2 opens) as well as crashing mid stream. Once we removed the plugin all was okay again. So not quite sure what could be causing that.

pcislocked commented 1 year ago

please do not use white theme my eyes burned to death while reading it

thanks

also, win-capture-audio works fine on me with 28.0.1. not sure about latest tho, i use it regularly so i cant really update it every time i feel like doing so.

pcislocked commented 1 year ago

damn

what a child