bozdoz / wp-plugin-leaflet-map

Add leaflet maps to Wordpress with shortcodes
https://wordpress.org/plugins/leaflet-map/
GNU General Public License v2.0
140 stars 71 forks source link

feat: 2-way shortcode helper inputs; resolves #68; fixes translations? #173

Open bozdoz opened 1 year ago

bozdoz commented 1 year ago

@hupe13 wondering if you know if the plugin is localized; I have no clue how to get i18n working.

hupe13 commented 1 year ago

You are using _e(). When you publish the development tree (trunk) or the stable Release the translators will see this here. I see the shortcode helper page in German, except "Reset Shortcodes", this is a new string.

Or what do you mean?

bozdoz commented 1 year ago

No, that's what I wanted to hear! I just have no idea how the translations work. Just newly generated a .pot file; so hopefully when this gets merged, that "Reset Shortcodes" button will be updated, eventually

hupe13 commented 1 year ago

Actually you don't need a pot file at all, as far as I understand it. I do not have one in my plugin.

bozdoz commented 1 year ago

wow, interesting

hupe13 commented 1 year ago

You are using _e().

The statement is incomplete. Must be: You are using _e() with a text domain.

bozdoz commented 1 year ago

Not sure where I left off with this. I don't think I was happy with it.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication