search

bozdoz / wp-plugin-leaflet-map

Add leaflet maps to Wordpress with shortcodes
https://wordpress.org/plugins/leaflet-map/
GNU General Public License v2.0
140 stars 71 forks source link

Basic WMS-Support for wp-plugin-leaflet-map #233

Closed jannefleischer closed 5 months ago

jannefleischer commented 10 months ago

I needed this for some project pages we are creating at our research institute. Feel free to merge it, if its stable enough for you.

Didn't do extensive testing as it is a work inprogress, though working stable enough.

bozdoz commented 10 months ago

This looks great I think! I'll have to actually try it out but generally looks clean. Not sure if everyone will be happy with it but hard to please everyone. I think it's ok to include.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jannefleischer commented 8 months ago

Can I do something to have this merged?

bozdoz commented 8 months ago

I haven't taken a look yet. For some reason didn't see you made changes. Thanks!

bozdoz commented 8 months ago

Does this look right to you? Just added it to the demo page

Screenshot 2023-10-30 at 8 53 08 PM

jannefleischer commented 8 months ago

You have already done all the necessary changes, don't you? If not: As I am an urban planner by heritage and not very experienced in merging code, I might need more instructions what I need to do...

Thanks for working on this!

bozdoz commented 8 months ago

I think my only question was attribution for the default wms layer. I attached a screenshot. Is that accurate? I don't recognize the domain name that the default wms url is set to.

jannefleischer commented 8 months ago

I added the attribution for the mundialis service (its just OpenStreetMap Data), so hopefully this can be merged now.

jannefleischer commented 5 months ago

@bozdoz Could you merge this, so it will arrive at the wordpress-plugins-repository soon? Or is there something I can do to make this happen? Would like to activate auto-update on my pages again... ;)

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

bozdoz commented 5 months ago

Seems to work. Thanks!

bozdoz commented 5 months ago

@jannefleischer Live in 3.4.0! Thanks!