search

bozoh / moodle-mod_simplecertificate

It's NOT RECOMMENDED to install version below 2.2.6 (MOODLE_31), due a security issues See more in README
17 stars 46 forks source link

Travis warning report in get_date_options() #156

Closed bozoh closed 7 years ago

bozoh commented 8 years ago

From: derek.henderson@remote-learner.net Date: Thu, 15 Sep 2016 17:19:06 -0400 Subject: Simple Certificate Module To: bozohhot@hotmail.com

Hi - my name is Derek Henderson and I am developer with Remote Learner.

One of my jobs is to evaluate plugins like yours for security and performance issues.

I have been looking at your plugin for Moodle 3.0 and Moodle 3.1. I have been using travis.ci as an evaluation tool.

When I run it with Moodle 2.9, its fine.

However, when I run it with Moodle 3.0 or Moodle 3.1 (see: https://travis-ci.org/POETGroup/moodle-mod_simplecertificate),

I get an error as shown below (see: https://travis-ci.org/POETGroup/moodle-mod_simplecertificate/jobs/160267996)

It does not seem to affect the performance of the plugin.

Just wondering if you have seen anything like it, or have a newer version available.

Thanks for your time..

PHP Notice: Undefined property: stdClass::$gradepointdefault in /home/trav is/build/moodle/lib/grade/grade_item.php on line 270
PHP Stack trace:
PHP 1. {main}() /home/travis/build/moodle/admin/tool/phpunit/cli/util.php :0
PHP 2. phpunit_util::install_site() /home/travis/build/moodle/admin/tool/ phpunit/cli/util.php:150
PHP 3. install_cli_database() /home/travis/build/moodle/lib/phpunit/class es/util.php:446
PHP 4. admin_apply_default_settings() /home/travis/build/moodle/lib/insta lllib.php:514
PHP 5. admin_get_root() /home/travis/build/moodle/lib/adminlib.php:6954
PHP 6. require() /home/travis/build/moodle/lib/adminlib.php:6933
PHP 7. core\plugininfo\mod->load_settings() /home/travis/build/moodle/adm in/settings/plugins.php:45
PHP 8. include() /home/travis/build/moodle/lib/classes/plugininfo/mod.php :89
PHP 9. simplecertificate_get_date_options() /home/travis/build/moodle/mod /simplecertificate/settings.php:30
PHP 10. simplecertificate_get_mods() /home/travis/build/moodle/mod/simplec ertificate/lib.php:436
PHP 11. grade_item::fetch_all() /home/travis/build/moodle/mod/simplecertif icate/lib.php:411
PHP 12. grade_object::fetch_all_helper() /home/travis/build/moodle/lib/gra de/grade_item.php:365
PHP 13. grade_item->__construct() /home/travis/build/moodle/lib/grade/grad e_object.php:182

bozoh commented 8 years ago

Using worker: worker-linux-docker-8f605598.prod.travis-ci.org:travis-linux-13

travis_fold:start:system_info Build system information Build language: php Build group: stable Build dist: precise Build id: 160267994 Job id: 160267996 travis-build version: ef82e8245 Build image provisioning date and time Thu Feb 5 15:09:33 UTC 2015 Operating System Details Distributor ID: Ubuntu Description: Ubuntu 12.04.5 LTS Release: 12.04 Codename: precise Linux Version 3.13.0-29-generic Cookbooks Version a68419e https://github.com/travis-ci/travis-cookbooks/tree/a68419e GCC version gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 Copyright (C) 2011 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

LLVM version clang version 3.4 (tags/RELEASE_34/final) Target: x86_64-unknown-linux-gnu Thread model: posix Pre-installed Ruby versions ruby-1.9.3-p551 Pre-installed Node.js versions v0.10.36 Pre-installed Go versions 1.4.1 Redis version redis-server 2.8.19 riak version 2.0.2 MongoDB version MongoDB 2.4.12 CouchDB version couchdb 1.6.1 Neo4j version 1.9.4 RabbitMQ Version 3.4.3 ElasticSearch version 1.4.0 Installed Sphinx versions 2.0.10 2.1.9 2.2.6 Default Sphinx version 2.2.6 Installed Firefox version firefox 31.0esr PhantomJS version 1.9.8 ant -version Apache Ant(TM) version 1.8.2 compiled on December 3 2011 mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T17:29:23+00:00) Maven home: /usr/local/maven Java version: 1.7.0_76, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-7-oracle/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux", version: "3.13.0-29-generic", arch: "amd64", family: "unix" travis_fold:end:system_info  travis_fold:start:fix.CVE-2015-7547 $ export DEBIAN_FRONTEND=noninteractive W: Size of file /var/lib/apt/lists/dl.hhvm.com_ubuntu_dists_precise_main_binary-amd64_Packages.gz is not what the server reported 2047 2461 W: Size of file /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_precise-backports_multiverse_source_Sources.gz is not what the server reported 5886 5888 W: Size of file /var/lib/apt/lists/ppa.launchpad.net_ubuntugis_ppa_ubuntu_dists_precise_main_binary-amd64_Packages.gz is not what the server reported 33653 36677 W: Size of file /var/lib/apt/lists/ppa.launchpad.net_ubuntugis_ppa_ubuntu_dists_precise_main_binary-i386_Packages.gz is not what the server reported 33699 36733 Reading package lists... Building dependency tree... Reading state information... The following extra packages will be installed: libc-bin libc-dev-bin libc6-dev Suggested packages: glibc-doc The following packages will be upgraded: libc-bin libc-dev-bin libc6 libc6-dev 4 upgraded, 0 newly installed, 0 to remove and 248 not upgraded. Need to get 8,840 kB of archives. After this operation, 14.3 kB disk space will be freed. Get:1 http://us.archive.ubuntu.com/ubuntu/ precise-updates/main libc6-dev amd64 2.15-0ubuntu10.15 [2,943 kB] Get:2 http://us.archive.ubuntu.com/ubuntu/ precise-updates/main libc-dev-bin amd64 2.15-0ubuntu10.15 [84.7 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ precise-updates/main libc-bin amd64 2.15-0ubuntu10.15 [1,177 kB] Get:4 http://us.archive.ubuntu.com/ubuntu/ precise-updates/main libc6 amd64 2.15-0ubuntu10.15 [4,636 kB] Fetched 8,840 kB in 0s (32.3 MB/s) Preconfiguring packages ... (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 70845 files and directories currently installed.) Preparing to replace libc6-dev 2.15-0ubuntu10.10 (using .../libc6-dev_2.15-0ubuntu10.15_amd64.deb) ... Unpacking replacement libc6-dev ... Preparing to replace libc-dev-bin 2.15-0ubuntu10.10 (using .../libc-dev-bin_2.15-0ubuntu10.15_amd64.deb) ... Unpacking replacement libc-dev-bin ... Preparing to replace libc-bin 2.15-0ubuntu10.10 (using .../libc-bin_2.15-0ubuntu10.15_amd64.deb) ... Unpacking replacement libc-bin ... Processing triggers for man-db ... Setting up libc-bin (2.15-0ubuntu10.15) ... (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 70844 files and directories currently installed.) Preparing to replace libc6 2.15-0ubuntu10.10 (using .../libc6_2.15-0ubuntu10.15_amd64.deb) ... Unpacking replacement libc6 ... Setting up libc6 (2.15-0ubuntu10.15) ... Setting up libc-dev-bin (2.15-0ubuntu10.15) ... Setting up libc6-dev (2.15-0ubuntu10.15) ... Processing triggers for libc-bin ... ldconfig deferred processing now taking place travis_fold:end:fix.CVE-2015-7547 travis_fold:start:git.checkout travis_time:start:02f94aa3 $ git clone --depth=50 --branch=POET_2.2.4 https://github.com/POETGroup/moodle-mod_simplecertificate.git POETGroup/moodle-mod_simplecertificate Cloning into 'POETGroup/moodle-mod_simplecertificate'... remote: Counting objects: 333, done. remote: Compressing objects: 0% (1/192)  remote: Compressing objects: 1% (2/192)  remote: Compressing objects: 2% (4/192)  remote: Compressing objects: 3% (6/192)  remote: Compressing objects: 4% (8/192)  remote: Compressing objects: 5% (10/192)  remote: Compressing objects: 6% (12/192)  remote: Compressing objects: 7% (14/192)  remote: Compressing objects: 8% (16/192)  remote: Compressing objects: 9% (18/192)  remote: Compressing objects: 10% (20/192)  remote: Compressing objects: 11% (22/192)  remote: Compressing objects: 12% (24/192)  remote: Compressing objects: 13% (25/192)  remote: Compressing objects: 14% (27/192)  remote: Compressing objects: 15% (29/192)  remote: Compressing objects: 16% (31/192)  remote: Compressing objects: 17% (33/192)  remote: Compressing objects: 18% (35/192)  remote: Compressing objects: 19% (37/192)  remote: Compressing objects: 20% (39/192)  remote: Compressing objects: 21% (41/192)  remote: Compressing objects: 22% (43/192)  remote: Compressing objects: 23% (45/192)  remote: Compressing objects: 24% (47/192)  remote: Compressing objects: 25% (48/192)  remote: Compressing objects: 26% (50/192)  remote: Compressing objects: 27% (52/192)  remote: Compressing objects: 28% (54/192)  remote: Compressing objects: 29% (56/192)  remote: Compressing objects: 30% (58/192)  remote: Compressing objects: 31% (60/192)  remote: Compressing objects: 32% (62/192)  remote: Compressing objects: 33% (64/192)  remote: Compressing objects: 34% (66/192)  remote: Compressing objects: 35% (68/192)  remote: Compressing objects: 36% (70/192)  remote: Compressing objects: 37% (72/192)  remote: Compressing objects: 38% (73/192)  remote: Compressing objects: 39% (75/192)  remote: Compressing objects: 40% (77/192)  remote: Compressing objects: 41% (79/192)  remote: Compressing objects: 42% (81/192)  remote: Compressing objects: 43% (83/192)  remote: Compressing objects: 44% (85/192)  remote: Compressing objects: 45% (87/192)  remote: Compressing objects: 46% (89/192)  remote: Compressing objects: 47% (91/192)  remote: Compressing objects: 48% (93/192)  remote: Compressing objects: 49% (95/192)  remote: Compressing objects: 50% (96/192)  remote: Compressing objects: 51% (98/192)  remote: Compressing objects: 52% (100/192)  remote: Compressing objects: 53% (102/192)  remote: Compressing objects: 54% (104/192)  remote: Compressing objects: 55% (106/192)  remote: Compressing objects: 56% (108/192)  remote: Compressing objects: 57% (110/192)  remote: Compressing objects: 58% (112/192)  remote: Compressing objects: 59% (114/192)  remote: Compressing objects: 60% (116/192)  remote: Compressing objects: 61% (118/192)  remote: Compressing objects: 62% (120/192)  remote: Compressing objects: 63% (121/192)  remote: Compressing objects: 64% (123/192)  remote: Compressing objects: 65% (125/192)  remote: Compressing objects: 66% (127/192)  remote: Compressing objects: 67% (129/192)  remote: Compressing objects: 68% (131/192)  remote: Compressing objects: 69% (133/192)  remote: Compressing objects: 70% (135/192)  remote: Compressing objects: 71% (137/192)  remote: Compressing objects: 72% (139/192)  remote: Compressing objects: 73% (141/192)  remote: Compressing objects: 74% (143/192)  remote: Compressing objects: 75% (144/192)  remote: Compressing objects: 76% (146/192)  remote: Compressing objects: 77% (148/192)  remote: Compressing objects: 78% (150/192)  remote: Compressing objects: 79% (152/192)  remote: Compressing objects: 80% (154/192)  remote: Compressing objects: 81% (156/192)  remote: Compressing objects: 82% (158/192)  remote: Compressing objects: 83% (160/192)  remote: Compressing objects: 84% (162/192)  remote: Compressing objects: 85% (164/192)  remote: Compressing objects: 86% (166/192)  remote: Compressing objects: 87% (168/192)  remote: Compressing objects: 88% (169/192)  remote: Compressing objects: 89% (171/192)  remote: Compressing objects: 90% (173/192)  remote: Compressing objects: 91% (175/192)  remote: Compressing objects: 92% (177/192)  remote: Compressing objects: 93% (179/192)  remote: Compressing objects: 94% (181/192)  remote: Compressing objects: 95% (183/192)  remote: Compressing objects: 96% (185/192)  remote: Compressing objects: 97% (187/192)  remote: Compressing objects: 98% (189/192)  remote: Compressing objects: 99% (191/192)  remote: Compressing objects: 100% (192/192)  remote: Compressing objects: 100% (192/192), done. Receiving objects: 0% (1/333)
Receiving objects: 1% (4/333)
Receiving objects: 2% (7/333)
Receiving objects: 3% (10/333)
Receiving objects: 4% (14/333)
Receiving objects: 5% (17/333)
Receiving objects: 6% (20/333)
Receiving objects: 7% (24/333)
Receiving objects: 8% (27/333)
Receiving objects: 9% (30/333)
Receiving objects: 10% (34/333)
Receiving objects: 11% (37/333)
Receiving objects: 12% (40/333)
Receiving objects: 13% (44/333)
Receiving objects: 14% (47/333)
Receiving objects: 15% (50/333)
Receiving objects: 16% (54/333)
Receiving objects: 17% (57/333)
Receiving objects: 18% (60/333)
Receiving objects: 19% (64/333)
Receiving objects: 20% (67/333)
Receiving objects: 21% (70/333)
Receiving objects: 22% (74/333)
Receiving objects: 23% (77/333)
Receiving objects: 24% (80/333)
Receiving objects: 25% (84/333)
Receiving objects: 26% (87/333)
Receiving objects: 27% (90/333)
Receiving objects: 28% (94/333)
Receiving objects: 29% (97/333)
Receiving objects: 30% (100/333)
Receiving objects: 31% (104/333)
Receiving objects: 32% (107/333)
Receiving objects: 33% (110/333)
Receiving objects: 34% (114/333)
Receiving objects: 35% (117/333)
Receiving objects: 36% (120/333)
Receiving objects: 37% (124/333)
Receiving objects: 38% (127/333)
Receiving objects: 39% (130/333)
Receiving objects: 40% (134/333)
Receiving objects: 41% (137/333)
Receiving objects: 42% (140/333)
Receiving objects: 43% (144/333)
Receiving objects: 44% (147/333)
Receiving objects: 45% (150/333)
Receiving objects: 46% (154/333)
Receiving objects: 47% (157/333)
Receiving objects: 48% (160/333)
Receiving objects: 49% (164/333)
Receiving objects: 50% (167/333)
Receiving objects: 51% (170/333)
Receiving objects: 52% (174/333)
Receiving objects: 53% (177/333)
Receiving objects: 54% (180/333)
Receiving objects: 55% (184/333)
Receiving objects: 56% (187/333)
Receiving objects: 57% (190/333)
Receiving objects: 58% (194/333)
Receiving objects: 59% (197/333)
Receiving objects: 60% (200/333)
Receiving objects: 61% (204/333)
Receiving objects: 62% (207/333)
Receiving objects: 63% (210/333)
Receiving objects: 64% (214/333)
Receiving objects: 65% (217/333)
Receiving objects: 66% (220/333)
Receiving objects: 67% (224/333)
Receiving objects: 68% (227/333)
Receiving objects: 69% (230/333)
Receiving objects: 70% (234/333)
Receiving objects: 71% (237/333)
Receiving objects: 72% (240/333)
Receiving objects: 73% (244/333)
Receiving objects: 74% (247/333)
Receiving objects: 75% (250/333)
Receiving objects: 76% (254/333)
Receiving objects: 77% (257/333)
Receiving objects: 78% (260/333)
Receiving objects: 79% (264/333)
Receiving objects: 80% (267/333)
Receiving objects: 81% (270/333)
Receiving objects: 82% (274/333)
Receiving objects: 83% (277/333)
Receiving objects: 84% (280/333)
Receiving objects: 85% (284/333)
Receiving objects: 86% (287/333)
Receiving objects: 87% (290/333)
Receiving objects: 88% (294/333)
Receiving objects: 89% (297/333)
Receiving objects: 90% (300/333)
Receiving objects: 91% (304/333)
remote: Total 333 (delta 173), reused 258 (delta 117), pack-reused 0 Receiving objects: 92% (307/333)
Receiving objects: 93% (310/333)
Receiving objects: 94% (314/333)
Receiving objects: 95% (317/333)
Receiving objects: 96% (320/333)
Receiving objects: 97% (324/333)
Receiving objects: 98% (327/333)
Receiving objects: 99% (330/333)
Receiving objects: 100% (333/333)
Receiving objects: 100% (333/333), 4.39 MiB | 0 bytes/s, done. Resolving deltas: 0% (0/173)
Resolving deltas: 1% (3/173)
Resolving deltas: 2% (4/173)
Resolving deltas: 4% (7/173)
Resolving deltas: 6% (11/173)
Resolving deltas: 8% (15/173)
Resolving deltas: 9% (16/173)
Resolving deltas: 12% (21/173)
Resolving deltas: 13% (23/173)
Resolving deltas: 16% (29/173)
Resolving deltas: 19% (33/173)
Resolving deltas: 26% (46/173)
Resolving deltas: 27% (47/173)
Resolving deltas: 28% (50/173)
Resolving deltas: 31% (54/173)
Resolving deltas: 32% (56/173)
Resolving deltas: 36% (63/173)
Resolving deltas: 40% (70/173)
Resolving deltas: 43% (75/173)
Resolving deltas: 44% (77/173)
Resolving deltas: 46% (81/173)
Resolving deltas: 47% (83/173)
Resolving deltas: 50% (88/173)
Resolving deltas: 52% (90/173)
Resolving deltas: 53% (93/173)
Resolving deltas: 56% (97/173)
Resolving deltas: 58% (102/173)
Resolving deltas: 60% (104/173)
Resolving deltas: 68% (118/173)
Resolving deltas: 73% (127/173)
Resolving deltas: 75% (130/173)
Resolving deltas: 85% (148/173)
Resolving deltas: 100% (173/173)
Resolving deltas: 100% (173/173), done. Checking connectivity... done.

travis_time:end:02f94aa3:start=1473968696990723187,finish=1473968697618606616,duration=627883429 $ cd POETGroup/moodle-mod_simplecertificate $ git checkout -qf 39ff5219e238eb7d29e543c1fd754e020bf60c08 travis_fold:end:git.checkout  This job is running on container-based infrastructure, which does not allow use of 'sudo', setuid and setguid executables. If you require sudo, add 'sudo: required' to your .travis.yml See https://docs.travis-ci.com/user/workers/container-based-infrastructure/ for details.

Setting environment variables from .travis.yml $ export MOODLE_BRANCH=MOODLE_30_STABLE $ export DB=mysqli

travis_time:start:057c41a6 $ phpenv global 5.6 2>/dev/null

travis_time:end:057c41a6:start=1473968699707004055,finish=1473968699724205839,duration=17201784 travis_time:start:0da31660 $ phpenv global 5.6

travis_time:end:0da31660:start=1473968699727825818,finish=1473968699743972924,duration=16147106 travis_time:start:00c36960 $ composer self-update Updating to version 20ee689bb464edfe7e57af6be8f03fb664f5db1d. Downloading: connection... Downloading: 100%  Use composer self-update --rollback to return to version 1d8f05f1dd0e390f253f79ea86cd505178360019

travis_time:end:00c36960:start=1473968699776864950,finish=1473968702361706955,duration=2584842005 travis_fold:start:cache.1 Setting up build cache $ export CASHER_DIR=$HOME/.casher travis_time:start:11660e3b $ Installing caching utilities

travis_time:end:11660e3b:start=1473968703140245970,finish=1473968703461882858,duration=321636888 travis_time:start:034b4b2a  travis_time:end:034b4b2a:start=1473968703466641518,finish=1473968703469976999,duration=3335481 travis_time:start:07343120 attempting to download cache archive fetching POET_2.2.4/cache-linux-precise-c83b850aa480d22dbceb9c8ee9e38b18b7808cfc640ec4c63c2276626e5f428b--php-5.6.tgz found cache

travis_time:end:07343120:start=1473968703473941993,finish=1473968704156730421,duration=682788428 travis_time:start:08f48d32  travis_time:end:08f48d32:start=1473968704160641858,finish=1473968704164033118,duration=3391260 travis_time:start:098d0ad2 adding /home/travis/.composer/cache to cache

travis_time:end:098d0ad2:start=1473968704167875972,finish=1473968705486288097,duration=1318412125 travis_fold:end:cache.1 $ php --version PHP 5.6.5 (cli) (built: Feb 12 2015 01:41:10) Copyright (c) 1997-2014 The PHP Group Zend Engine v2.6.0, Copyright (c) 1998-2014 Zend Technologies with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies with Xdebug v2.2.7, Copyright (c) 2002-2015, by Derick Rethans $ composer --version Composer version 1.2-dev (20ee689bb464edfe7e57af6be8f03fb664f5db1d) 2016-09-14 16:06:37  travis_fold:start:before_install.1 travis_time:start:16a852ac $ cd ../..

travis_time:end:16a852ac:start=1473968705693051251,finish=1473968705696280667,duration=3229416 travis_fold:end:before_install.1 travis_fold:start:before_install.2 travis_time:start:0e401860 $ composer selfupdate Updating to version 1.2.1 (stable channel). Downloading: Connecting... Downloading: 100%  Use composer self-update --rollback to return to version 20ee689bb464edfe7e57af6be8f03fb664f5db1d

travis_time:end:0e401860:start=1473968705700274229,finish=1473968707796543075,duration=2096268846 travis_fold:end:before_install.2 travis_fold:start:before_install.3 travis_time:start:075a66e0 $ composer create-project -n --no-dev --prefer-dist moodlerooms/moodle-plugin-ci ci dev-poet You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug Installing moodlerooms/moodle-plugin-ci (dev-poet cef345ba1424f702400c48dce19309635d4f706b)

Created project in ci Loading composer repositories with package information Installing dependencies from lock file

Generating autoload files

travis_time:end:075a66e0:start=1473968707800599235,finish=1473968714183149984,duration=6382550749 travis_fold:end:before_install.3 travis_fold:start:before_install.4 travis_time:start:005b1859 $ export PATH="$(cd ci/bin; pwd):$(cd ci/vendor/bin; pwd):$PATH"

travis_time:end:005b1859:start=1473968714187212337,finish=1473968714191533875,duration=4321538 travis_fold:end:before_install.4 travis_fold:start:install travis_time:start:002659e9 $ moodle-plugin-ci install

 0/7 [>---------------------------] 0% < 1 sec [Starting install]  1/7 [====>-----------------------] 14% < 1 sec [Cloning Moodle]  2/7 [========>-------------------] 28% 10 secs [Moodle assets]  3/7 [============>---------------] 42% 10 secs [Install plugins]  4/7 [================>-----------] 57% 10 secs [Install dependencies]  5/7 [====================>-------] 71% 33 secs [Initialize test suite]    [Moodlerooms\MoodlePluginCI\Process\MoodlePhpException]   PHP error message was detected when running this command:   php -d log_errors=1 -d error_log=NULL /home/travis/build/moodle/admin/too   l/phpunit/cli/util.php --install   Moodle scripts should run without any PHP errors.   Error Output   ============   PHP Notice: Undefined property: stdClass::$gradepointdefault in /home/trav   is/build/moodle/lib/grade/grade_item.php on line 270   PHP Stack trace:   PHP 1. {main}() /home/travis/build/moodle/admin/tool/phpunit/cli/util.php   :0   PHP 2. phpunit_util::install_site() /home/travis/build/moodle/admin/tool/   phpunit/cli/util.php:150   PHP 3. install_cli_database() /home/travis/build/moodle/lib/phpunit/class   es/util.php:446   PHP 4. admin_apply_default_settings() /home/travis/build/moodle/lib/insta   lllib.php:514   PHP 5. admin_get_root() /home/travis/build/moodle/lib/adminlib.php:6954   PHP 6. require() /home/travis/build/moodle/lib/adminlib.php:6933   PHP 7. core\plugininfo\mod->load_settings() /home/travis/build/moodle/adm   in/settings/plugins.php:45   PHP 8. include() /home/travis/build/moodle/lib/classes/plugininfo/mod.php   :89   PHP 9. simplecertificate_get_date_options() /home/travis/build/moodle/mod   /simplecertificate/settings.php:30   PHP 10. simplecertificate_get_mods() /home/travis/build/moodle/mod/simplec   ertificate/lib.php:436   PHP 11. grade_item::fetch_all() /home/travis/build/moodle/mod/simplecertif   icate/lib.php:411   PHP 12. grade_object::fetch_all_helper() /home/travis/build/moodle/lib/gra   de/grade_item.php:365   PHP 13. grade_item->__construct() /home/travis/build/moodle/lib/grade/grad   e_object.php:182   

install [--moodle MOODLE] [--data DATA] [--branch BRANCH] [--plugin PLUGIN] [--db-type DB-TYPE] [--db-user DB-USER] [--db-pass DB-PASS] [--db-name DB-NAME] [--db-host DB-HOST] [--not-paths NOT-PATHS] [--not-names NOT-NAMES] [--extra-plugins EXTRA-PLUGINS]

travis_time:end:002659e9:start=1473968714195472880,finish=1473968815926035223,duration=101730562343  The command "moodle-plugin-ci install" failed and exited with 1 during .

Your build has been stopped.

bozoh commented 7 years ago

Now i understand th bug, it's happens when i in settings pages, and the code try do get grade items from the course ... only need to put a check id courseid=siteid

rlcharles commented 7 years ago

@bozoh The commit you suggested also fixes an issue with behat failing to initialize with a similar error as travis. My only recommendation is to use the Moodle coding style guidelines. Inline Comments should be in the format // This is a comment. See https://docs.moodle.org/dev/Coding_style#Inline_comments

bozoh commented 7 years ago

@rlcharles you are right, i know this cody style, but is a bit confusing when you are programing in other languages at same time (R), why PHP accpets # as comment too :D , sorry, it's fixed now