search

bp / ResSimpy

A Python library for working with Reservoir Simulators
Apache License 2.0
11 stars 4 forks source link

Add a warning flag everytime a conflicting unit system/date format is found in a subfile. #186

Open jonnyh404 opened 1 year ago

jonnyh404 commented 1 year ago

Finding units/dateformat changes is already supported when loading/reading the wells and surface network. This method needs to check the run_units in the NexusSimulator instance and return a warnings.warn message to the user when the new unit/dateformat differs to the run_units.

SahilDave04 commented 1 year ago

Hey! I am interested in solving the issue, can you direct me to the file where changes need to made.

jonnyh404 commented 1 year ago

Hi Sahil, thanks for getting in touch about this issue.

I believe there are two methods within the nexus_file_operations.py: check_for_and_populate_common_input_data and check_property_in_line

These methods check the files for units or date formats.

SahilDave04 commented 1 year ago

Do you just need a warning message displayed when format doesn't match?