search

bp / resqpy

Python API for working with RESQML models
https://resqpy.readthedocs.io/en/latest/
MIT License
52 stars 13 forks source link

Implement a resqpy RelPerm class inheriting from DataFrame #155

Closed andy-beer closed 3 years ago

andy-beer commented 3 years ago

The existing olio.dataframe module includes a general purpose DataFrame class for storing and retrieving numerical pandas dataframe data in a RESQML object (creatively re-using the Grid2DRepresentation class and related classes).

This issue proposes implementing a specialist RelPerm class which inherits from DataFrame.

(Similarly capillary pressure data, rock compressibility etc. could have specialised resqpy classes.)

andy-beer commented 3 years ago

Kadija will be working on this issue – awaiting username to assign.

kadijahassanali commented 3 years ago

Hi Andy, I do have a git account associated with my bp credentials but I can't sign in using those. Instead, I've signed in using my personal account. image

andy-beer commented 3 years ago

Hello Kadija,

It is strange that your bp git account is not working – we can probably get that fixed. I think it's okay to carry on with your personal account until then.

By the way, I will be making a small change to the DataFrame init​​ arguments to accept a uuid when initialising from an existing RESQML object, and deprecating the support_root argument. This is a change we've been making to all the class initialisers. The tutorials should be up-to-date but older material such as those presentation videos indicate use of an xml root for initialisation, which will now cause a deprecation warning.

Kind regards, Andy.

From: kadijahassanali @.> Sent: 15 July 2021 21:48 To: bp/resqpy @.> Cc: Beer, Andy (NAG PARTNERr) @.>; Author @.> Subject: Re: [bp/resqpy] Implement a resqpy RelPerm class inheriting from DataFrame (#155)

Hi Andy, I do have a git account associated with my bp credentials but I can't sign in using those. Instead, I've signed in using my personal account. [image]https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F71336336%2F125848376-889c0034-6513-4df3-8a8a-743efc3f5a8a.png&data=04%7C01%7Candy.beer%40bp.com%7C97870652781744a91af608d947c989b1%7Cea80952ea47642d4aaf45457852b0f7e%7C0%7C0%7C637619753185751888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=D5wChQYqXR9Zi3SdXqGklSykXw9W%2FliAM89ayJOGQbA%3D&reserved=0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbp%2Fresqpy%2Fissues%2F155%23issuecomment-880967628&data=04%7C01%7Candy.beer%40bp.com%7C97870652781744a91af608d947c989b1%7Cea80952ea47642d4aaf45457852b0f7e%7C0%7C0%7C637619753185761845%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=iug2T6aFL9qGWWKlQ64VZIt7NvQx5u99LAQ8WFiIIsg%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQ7YHGAPUP4GTBQJIXXIKTDTX43RJANCNFSM5ANYHM3Q&data=04%7C01%7Candy.beer%40bp.com%7C97870652781744a91af608d947c989b1%7Cea80952ea47642d4aaf45457852b0f7e%7C0%7C0%7C637619753185761845%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=A2EddUW5zZbxkfKzitfFOO57ng7n7Wm3KwKVPdfWwFM%3D&reserved=0.

berland commented 3 years ago

You might want to have look at http://github.com/equinor/pyscal which I maintain. It contains a Dataframe representations both for the parametrization of relperm, and also a dataframe representation of the tabulated values.

andy-beer commented 3 years ago

Sorry @berland , I meant to leave the following comment before closing this issue:

Issue #176 has been raised to improve interoperability of the resqpy RelPerm class with equinor/pyscal. @kadijahassanali is working on this.