handling of grid geometry stored in parametric line form

bp / resqpy

Python API for working with RESQML models

https://resqpy.readthedocs.io/en/latest/

MIT License

51 stars 14 forks source link

Closed andy-beer closed 9 months ago

andy-beer commented 9 months ago

This change introduces support for the parametric line form of grid geometry. There are some restrictions:

internal python representation is as before (convert on read and write)
only a constant line kind index of 1 and knot count of 2 is supported (straight lines)
horizontal or undefined parametric lines will raise an assertion error
undefined topmost or basal cached points for any pillar will cause failure if writing in parametric line form

The code aims to be compatible with the geometry representation used by RMS when exporting to RESQML.

Resolves issue #723

RMS is a trademark of AspenTech.

codecov[bot] commented 9 months ago

Patch coverage is 96.35% of modified lines.

Files Changed	Coverage
resqpy/grid/_points_functions.py	`92.06%`
resqpy/grid/_create_grid_xml.py	`100.00%`
resqpy/grid/_grid.py	`100.00%`
resqpy/grid/_grid_types.py	`100.00%`
resqpy/grid/_write_hdf5_from_caches.py	`100.00%`
resqpy/olio/xml_et.py	`100.00%`

:loudspeaker: Thoughts on this report? Let us know!.