FIX: allows yearOffset at 0 for geologic time series

bp / resqpy

Python API for working with RESQML models

https://resqpy.readthedocs.io/en/latest/

MIT License

51 stars 14 forks source link

FIX: allows yearOffset at 0 for geologic time series #797

Closed adamchengtkc closed 2 months ago

adamchengtkc commented 2 months ago

Currently Geological time series can't be 0 as this line check for falsy. Suggesting this PR to check for int instead. User case: Storing values that goes from geological past to present-day which is denoted as 0

andy-beer commented 2 months ago

Thanks for this change. I am going to replicate it in a separate branch as the CodeCov aspect of the unit test pipeline is currently falling over when running from the equinor:master branch. (I will also ask a colleague to look into whether we can get that working, for future changes.)

andy-beer commented 2 months ago

This Pull Request has been replaced by #798 which is functionally equivalent and has been merged into master. I am therefore closing this PR without merging. FAO. @adamchengtkc