search

bp74 / StageXL_Samples

Sample applications showing features of the StageXL library.
BSD 2-Clause "Simplified" License
65 stars 29 forks source link

RichTextField extension #3

Closed alexgann closed 10 years ago

alexgann commented 10 years ago

Had to add pubspec dependency to the stagexl_richtextfield repo. Perhaps I should push it to pub at some point, or move it under bp74?

bp74 commented 10 years ago

Hi Alex! Thanks for the pull request, it looks good to me. But as you wrote in your note, it would be better to upload your package to Pub. If someone does not use Git he can't compile the samples any longer.

alexgann commented 10 years ago

Got richtextfield onto pub - updated PR to use pub reference.

bp74 commented 10 years ago

Hi Alex, thanks a lot for the change. The sample is already online on the StageXL samples page.

I noticed that the StageXL_RichtTextField has a dependency to package:xml. But it seems that you don't use it. If i'm right it would be better to remove it from pubspec.yaml next time you publish your package.

Thanks again for this great extension to StageXL and for the sample.

alexgann commented 10 years ago

I definitely will - that was a dependency in Saso's original code where he had the flash-generated html being parsed by the xml package.

Thanks!