bp88 / JSS-Scripts

Random scripts for use in the Jamf Pro
188 stars 61 forks source link

Passwords with "$" breaks upgrade #34

Open mrazishere opened 2 years ago

mrazishere commented 2 years ago

https://github.com/bp88/JSS-Scripts/blob/d337cdffa8052c65aafabeddaa68a90315b1ffa8/OS_Upgrade.sh#L881

Doing some test with Monterey Self Service upgrade on M1 Macs and noticed upgrade failing, possibly due to mac password contains "$" in it. FV2 is enabled on all our machines. Partial jamf policy logs below:

can't read "after": no such variable while executing "send -- "before$after\n"" (file "/dev/fd/50" line 11)

/Library/Application Support/JAMF/tmp/OS_Upgrade.sh: line 897: unset: `before$after': not a valid identifier startosinstall did not succeed. See log at: /var/log/installmacos_211115064221.log and /var/log/install.log and /var/log/system.log

Upgraded successfully after replacing "$" character in mac password