Closed green3g closed 4 years ago
The line that's causing the issue looks like its here:
if (!MARKERS.includes(marker)) {
throw 'Invalid JPEG.';
}
In my case, the marker is 24172. I have no idea what this means, but hopefully someone can lend some insight to getting this fixed.
For reference, my image data is here:
Seeing related issues with jpeg issues - anyone ever seen stuff like this - where half the image is shaded a different color?
Throwing of exception for image improved by commit https://github.com/bpampuch/pdfmake/commit/2a06c5cf4dfe155f9421bdb79c617b6b4076795c.
We also have a problem with some images that are reported as apparently having invalid markers. This JPEG is an example - it renders fine in an image tag in HTML.
Diagnosing issues with pdfmake can be incredibly difficult, specifically I just found a case where an image I was adding to a PDF was throwing "Invalid JPEG" Inside the buffer library and PDFMake was swallowing this error making it super difficult to diagnose.
First of all, the image is not invalid, it displays fine in an image tag but buffer is having an issue for some reason. But I think how PDFmake could improve is by at least logging some sort of error so that I can at least identify the reason for why my pdf is failing to locate an image.