search

bpampuch / pdfmake

Client/server side PDF printing in pure JavaScript
http://pdfmake.org
Other
11.6k stars 2.03k forks source link

SharedArrayBuffers and COOP / COEP #2216

Open mrchibai opened 3 years ago

mrchibai commented 3 years ago

Chrome and Firefox adding new security called Cross-Origin-Opener-Policy (COOP) and Cross-Origin-Embedder-Policy (COEP). Needed wherever SharedArrayBuffers is used for WebAssembly threads.

Any chance pdfmake can add these when using the SharedArrayBuffers?

Connum commented 3 years ago

I'm still trying to figure out what this means... Will pdfmake suddenly break with an upcoming Chrome release, or will the fallbacks for browsers that don't support SharedArrayBuffers at all also come into play when it stops working in Chrome? However, I read that Firefox already has the Cross-Origina security meachanisms in place when using SharedArrayBuffer and pdfmake works in Firefox without problems...

paulosobrinho33 commented 3 years ago

Hello @bpampuch and everyone,

First of all I would to thank you for the great work with pdfmake. It is the best pdf library we found to generate pdfs. Unfortunately pdfmake 0.2.0 (and 0.1.72) is causing an error "ReferenceError: SharedArrayBuffer is not defined" in my project when running on Firefox and Safari. Currently is working just in Chrome. I would like to know if there is any chance to this issue be solved in the short term, otherwise we will need to migrate to another library.

liborm85 commented 3 years ago

Tested on Firefox and pdfmake works ok. Attach runnable example for reproduce issue.

paulosobrinho33 commented 3 years ago

Hi @liborm85 ,

Please accept my apologies. The error is not being caused by pdfmake, but by a plugin we were using (https://github.com/sebasdb2111/markdown2pdfmake). I will ask the author of this plugin if any correction could be expected in the short term.