search

bpanel-org / bpanel

A Blockchain Management System, powered by bcoin
https://bpanel.org
Other
53 stars 23 forks source link

client config param `host` will never get checked #170

Closed pinheadmz closed 5 years ago

pinheadmz commented 5 years ago

See: https://github.com/bpanel-org/bpanel/blob/development/server/utils/clients.js#L70

  let hostname =
    config.str('node-host', '127.0.0.1') || config.str('host', '127.0.0.1');

Whether or not node-host is set in config, the left side of this expression will always return a truthy value, meaning host will never actually get tested.