bparli / fastping-rs

ICMP ping library in Rust inspired by go-fastping and AnyEvent::FastPing Perl module
MIT License
76 stars 12 forks source link

add_ipaddr and remove_ipaddr should return a Result #34

Open itsmexxie opened 1 year ago

itsmexxie commented 1 year ago

First off, this is a very nice and simple pinging crate, so thank you for writing this. However, it would be nice if the functions add_ipaddr and remove_ipaddr returned a result of their IP parsing instead of handling it on their own. Them parsing it on their own can result in the pinger running indefinitely when a wrong IP is specified and therefore no IPs are present.