search

bparmentier / OpenBikeSharing

Shared bikes availability in your city
https://openbikesharing.org
Other
67 stars 56 forks source link

No station names in station list #6

Closed woutersj closed 9 years ago

woutersj commented 9 years ago

On the Fairphone FP1 I get only a list of P signs and a number next to it in the station list. There are no station names.

bparmentier commented 9 years ago

That's strange. Is it the first time you try the app? Which version is it? Do you have the same problem if you select another bike network?

woutersj commented 9 years ago

I am using v1.3 (from f-droid). I have used the app since 1.1.3, but have always had this issue. The station names are displayed in the map view though. The same package on another phone does not have this issue. Removing and reinstalling has no effect. Neither does selecting another bike network.

screenshot_2014-09-20-15-57-39

bparmentier commented 9 years ago

Could you post a logcat of when you open the application? Also, is the displayed entry (the "P 13") clickable? And I guess it takes all the screen, is it right?

woutersj commented 9 years ago

The entry is clickable (goes to station details). One item takes up the entire screen, but the list is scrollable, so there are other items of similar size below it.

bparmentier commented 9 years ago

I watched your logcat. However I cannot find anything wrong with it.

I'm sorry, I can't reproduce your bug so I don't really know how to manage it...

Are you able to build the app yourself? I think it could be related with the file app/src/main/res/layout/station_list_item.xml. Each element of a line is defined in there. Try playing with the values of android:padding*, android:layout_width or android:layout_height and tell me if it goes better.

woutersj commented 9 years ago

I haven't had much success so far (I don't have a clue about Android development). I can get text to display by removing the ImageViews in station_list_item.xml, but then no stations show up in the favorites list.

I have also managed to reproduce the issue in a virtual Nexus S device, with a 4" 480x800 screen running Android 4.2.2. The same virtual device with Android 4.4.2 works fine.

bparmentier commented 9 years ago

I found what was wrong! In one ImageView, the id referenced in layout_toStartOf was not the same as the one in layout_toLeftOf (and should have been). It seems that layout_toStartOf was used on Android 4.2 and layout_toLeftOf was used on Android 4.4 (layout_toStartOf was introduced in 4.2 for right-to-left locales).

I should have tested my app on all targeted Android version. Lesson learned 😉

Tell me if this works for you, and I'll push an update.

Thanks a lot for taking the time to report the bug!

woutersj commented 9 years ago

Great, that did it! Thanks a lot for this nice open source app.