search

bpatrik / pigallery2

A fast directory-first photo gallery website, with rich UI, optimized for running on low resource servers (especially on raspberry pi)
http://bpatrik.github.io/pigallery2/
MIT License
1.73k stars 202 forks source link

Consider supporting bmp format #705

Open ssnepenthe opened 11 months ago

ssnepenthe commented 11 months ago

I noticed that some of my images do not appear in the gallery... Looking closer it seems to be because they are all bmp format.

The list of supported formats from the readme does not include bmp, however you have mentioned here and here that they should be supported.

I am not sure whether this is a bug or by design, but would you consider supporting bmp images for future versions?

mrtnbr commented 11 months ago

Did you add the BMP format to the Supported photo formats option in the Settings/Admin page?

bpatrik commented 11 months ago

Sharp (the used image manipulation lib) does not support it out of the box:

https://github.com/lovell/sharp/issues/806 https://github.com/lovell/sharp/issues/543

You can tune the Docker file to build libvips with BMP support. If you manage to make it work, feel free to send a PR.

-- Sorry for being brief, sent from my phone.

On Thu, 31 Aug 2023, 10:44 mrtnbr, @.***> wrote:

Did you add the BMP format to the Supported photo formats option in the Settings/Admin page?

— Reply to this email directly, view it on GitHub https://github.com/bpatrik/pigallery2/issues/705#issuecomment-1700616903, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZKA5QJIWTE44DB2XMVNKTXYBFFPANCNFSM6AAAAAA4E6756M . You are receiving this because you are subscribed to this thread.Message ID: @.***>