bpatrik / pigallery2

A fast directory-first photo gallery website, with rich UI, optimized for running on low resource servers (especially on raspberry pi)
http://bpatrik.github.io/pigallery2/
MIT License
1.7k stars 193 forks source link

Add a faces_count keyword #911

Open enrique-lozano opened 1 month ago

enrique-lozano commented 1 month ago

Is your feature request related to a problem? Please describe. Let's say I want to filter/search only for photos of me and my partner alone. To achieve this, I think I need to put in the filter searchbar this: max_faces:2 min_faces:2 person:me person:partner.

Describe the solution you'd like I think this could be simplified if we have something like a faces_count keyword, to convert this expression in faces_count:2 person:me person:partner. This would be really more readable than the current solution.

Describe alternatives you've considered (optional) Other alternative can be the whole modification of the current filter system. For example we can remove all the max and min keywords, and have filters like faces_count<3 instead of max_faces:4

enrique-lozano commented 1 month ago

The issue and the possible improvement can be applied for the rest of the range keywords. That is, max-rating, min-rating, max-resolution, min-resolution

bpatrik commented 1 month ago

there is already something this, but called max persons or similar.

On Sat, Jun 8, 2024 at 9:20 AM Enrique Lozano Cebriano < @.***> wrote:

The issue and the possible improvement can be applied for the rest of the range keywords. That is, max-rating, min-rating, max-resolution, min-resolution

— Reply to this email directly, view it on GitHub https://github.com/bpatrik/pigallery2/issues/911#issuecomment-2155851924, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZKA5REOVM5FY4FDFYFAS3ZGKWFRAVCNFSM6AAAAABI7YH3C6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVHA2TCOJSGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

enrique-lozano commented 1 month ago

Mmm, I don't so, what you refer is max-faces, but I'm an asking for another tag called faces-count, to not have to put a min and a max if you want a specific count:

image

bpatrik commented 1 week ago

ahh I see. short answer: No :D

Long answer I - eventually, at some point, dont know when- would like to refactor search to use relations: so having like: faces>=2, rating=1, resolution<12324

Until then the app has the requested functionality and the enhancement I just mentioned will do this requested improvement. Let me know if you would like to contribute and take this on.