bpbond / cosore

Data, metadata, and software tools for the COSORE database of continuous soil respiration measurements
Creative Commons Attribution 4.0 International
31 stars 10 forks source link

Second version of ESSD figures #214

Closed stephpenn1 closed 4 years ago

stephpenn1 commented 4 years ago

image

image

stephpenn1 commented 4 years ago

Still to do:

stephpenn1 commented 4 years ago

@bpbond do not merge yet

stephpenn1 commented 4 years ago

Thoughts? @bpbond

image

bpbond commented 4 years ago

Ooh beautiful! Only possible suggestion might be COSORE points in a more contrasting color? Not sure.


From: Stephanie Pennington notifications@github.com Sent: Monday, April 20, 2020 1:38:28 PM To: bpbond/cosore cosore@noreply.github.com Cc: Bond-Lamberty, Benjamin BondLamberty@pnnl.gov; Mention mention@noreply.github.com Subject: Re: [bpbond/cosore] Second version of ESSD figures (#214)

Thoughts?

[image]https://protect2.fireeye.com/v1/url?k=75fe59bf-294b6770-75fe73aa-0cc47adc5e60-dc7f14021463489e&q=1&e=860fc16e-48e3-4aad-bb62-55ce81cccb4e&u=https%3A%2F%2Fuser-images.githubusercontent.com%2F20341158%2F79781857-29104600-830c-11ea-82cc-f290fa6c3d83.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=a5e8bf0c-f95d81c3-a5e89519-0cc47adc5e60-d2d14a1ca711a819&q=1&e=860fc16e-48e3-4aad-bb62-55ce81cccb4e&u=https%3A%2F%2Fgithub.com%2Fbpbond%2Fcosore%2Fpull%2F214%23issuecomment-616706402, or unsubscribehttps://protect2.fireeye.com/v1/url?k=bb9c9ba2-e729a56d-bb9cb1b7-0cc47adc5e60-5281d821ad282833&q=1&e=860fc16e-48e3-4aad-bb62-55ce81cccb4e&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAO5U5HINZSTW3QSBRMCMLLRNSCBJANCNFSM4ML3SDQQ.

stephpenn1 commented 4 years ago

Everything is up to date. I am having trouble sourcing the mat-map.R script in the Rmd, otherwise this is ready to go

> source("mat-map.R")
Error in .getDataPath(path) : path does not exist: essd/
bpbond commented 4 years ago

@stephpenn1 When I try to knit the RMarkdown, I get an error in line 403, data_meta not found. 😕

stephpenn1 commented 4 years ago

When I knit I get an error about not having the google sheet authors... but line 353 is...

csr_table(table = 'data') %>% left_join(db) -> data_meta

bpbond commented 4 years ago

line 353 is

That doesn't appear in the diff, so may not have gotten pushed?

Screen Shot 2020-04-24 at 11 35 16 AM

bpbond commented 4 years ago

@stephpenn1 I'd like to turn back to this later this week...could you push up any code you have by then, and fx me needed WorldClim file(s)? Thank you.

stephpenn1 commented 4 years ago

@bpbond Everything is up to date on my end. I addressed your comment abt the path, see above. Also, lines 14 and 15 download the WorldClim data, so you shouldn't need my local files right?

bpbond commented 4 years ago

👏 @stephpenn1