search

bpbond / cosore

Data, metadata, and software tools for the COSORE database of continuous soil respiration measurements
Creative Commons Attribution 4.0 International
31 stars 10 forks source link

d20200109_HIRANO_PDB ports different in ports and data #243

Open BernhardAhrens opened 2 years ago

BernhardAhrens commented 2 years ago

I think I have discovered an inconsistency in the d20200109_HIRANO_PDB dataset:

ds = csr_dataset("d20200109_HIRANO_PDB")

unique(ds$ports$CSR_PORT) # gives 0
unique(ds$data$CSR_PORT) # gives 1 2 3 4 5 6

To my mind, all ports should be referenced in ports, so that the user knows which CSR_MSMT_VAR they are looking at.

Thanks for putting this great effort together!

bpbond commented 2 years ago

Ah good catch @BernhardAhrens - thank you! I will fix.

bpbond commented 2 years ago

Note to self: write an automated test to catch this.