search

bpd1069 / naclports

Automatically exported from code.google.com/p/naclports
0 stars 0 forks source link

naclports should use the same convention as the SDK for NACL_SDK_ROOT #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Try and build naclports with a recent SDK
2. Note it fails. This is because the SDK examples assume a pepper_XX component 
to the path, but naclports doesn't.

See 
https://groups.google.com/forum/#!msg/native-client-discuss/3YnKJg8Kams/dA56j8tS
OoQJ

Brad, Evgeny do you agree this is the right way to correct this situation?

Original issue reported on code.google.com by bradc...@google.com on 2 Sep 2012 at 4:56

GoogleCodeExporter commented 9 years ago

Original comment by bradc...@google.com on 2 Sep 2012 at 4:58

GoogleCodeExporter commented 9 years ago

Original comment by bradc...@google.com on 2 Sep 2012 at 5:02

GoogleCodeExporter commented 9 years ago 
I figure we should sort this out here before replying definitively on the forum.

So my understanding of the state of the world is:
- naclports assumes NACL_SDK_ROOT includes pepper_XX
- the sdk examples (now using makefiles) assume NACL_SDK_ROOT includes 
pepper_XX (but will auto-set NACL_SDK_ROOT if not currently set)

There was a brief span of time when the sdk examples did use NACL_SDK_ROOT 
without pepper_XX, but this was fairly brief if I recall.

So, unless I'm missing something, this doc just doesn't reflect the current 
state of the world. As the doc also refers to a number of defunct aspects of 
the SDK (scons build, cmake) I suspect we'll want to either update it to 
reflect how things are, or drop it and redirect?

Original comment by bradnelson@google.com on 2 Sep 2012 at 9:24

GoogleCodeExporter commented 9 years ago 
So?..

Original comment by techtonik@gmail.com on 3 Nov 2012 at 6:13

GoogleCodeExporter commented 9 years ago 
The documentation referred to for the SDK is obsolete.
The current documentation is located here:
https://developers.google.com/native-client/dev/devguide/devcycle/vs-addin

Deleting the old docs here:
http://www.chromium.org/nativeclient/sdk/vs-nacl-development

The convention of NACL_SDK_ROOT pointing to pepper_XYZ (as in nacl-mounts) is 
the current best practice.

Original comment by bradnelson@google.com on 5 Nov 2012 at 11:26