bpeacock44 / targeted_microbiome_via_blast

For developing wrapper scripts for our lab's targeted amplicon microbiome pipeline that utilizes blast for taxonomic assignments
1 stars 0 forks source link

Missing echo statement in mbio_part1 #9

Closed mcuaya1 closed 4 months ago

mcuaya1 commented 4 months ago

https://github.com/bpeacock44/targeted_microbiome_via_blast/blob/4a8b36e2ce29784bb77630f2b8639de6815e65b0/pipeline_scripts/mbio_part1.sh#L83

This line here is missing an echo statement. This currently causes the program to crash on part 1.

bpeacock44 commented 4 months ago

Hi Mario,

Thank you - sorry about that! I'm going to test everything again right now.

-Beth

On Tue, Jun 25, 2024 at 10:26 PM Mario Cuaya @.***> wrote:

Assigned #9 https://github.com/bpeacock44/targeted_microbiome_via_blast/issues/9 to @bpeacock44 https://github.com/bpeacock44.

— Reply to this email directly, view it on GitHub https://github.com/bpeacock44/targeted_microbiome_via_blast/issues/9#event-13292039270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWZYN33SFTOVUKZ5DBHJBDZJJGGZAVCNFSM6AAAAABJ5D2QBOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI4TEMBTHEZDOMA . You are receiving this because you were assigned.Message ID: <bpeacock44/targeted_microbiome_via_blast/issue/9/issue_event/13292039270@ github.com>

bpeacock44 commented 4 months ago

Fixed!

On Wed, Jun 26, 2024 at 9:54 AM Beth Peacock @.***> wrote:

Hi Mario,

Thank you - sorry about that! I'm going to test everything again right now.

-Beth

On Tue, Jun 25, 2024 at 10:26 PM Mario Cuaya @.***> wrote:

Assigned #9 https://github.com/bpeacock44/targeted_microbiome_via_blast/issues/9 to @bpeacock44 https://github.com/bpeacock44.

— Reply to this email directly, view it on GitHub https://github.com/bpeacock44/targeted_microbiome_via_blast/issues/9#event-13292039270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWZYN33SFTOVUKZ5DBHJBDZJJGGZAVCNFSM6AAAAABJ5D2QBOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI4TEMBTHEZDOMA . You are receiving this because you were assigned.Message ID: <bpeacock44/targeted_microbiome_via_blast/issue/9/issue_event/13292039270 @github.com>

mcuaya1 commented 4 months ago

Okay, sounds! No worries at all. I'm processing data through the pipeline again so if I run into any issues, I'll open another issue on here so it can be addressed. We can close this issue currently if it has been addressed.

bpeacock44 commented 4 months ago

Thank you - as mentioned before I am not used to collaborating over github so I apologize again for the inconvenience! I should've had a branch going instead of directly changing the main.

On Wed, Jun 26, 2024 at 10:37 AM Mario Cuaya @.***> wrote:

Okay, sounds! No worries at all. I'm processing data through the pipeline again so if I run into any issues, I'll open another issue on here so it can be addressed. We can close this issue currently if it has been addressed.

— Reply to this email directly, view it on GitHub https://github.com/bpeacock44/targeted_microbiome_via_blast/issues/9#issuecomment-2192276897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWZYNZ7DXBG2SI5PJERDW3ZJL357AVCNFSM6AAAAABJ5D2QBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGI3TMOBZG4 . You are receiving this because you were mentioned.Message ID: @.***>

mcuaya1 commented 4 months ago

No problem, I understand completely. I'll go ahead and close this issue in a bit as it has been resolved, if you would like to continue using this github feature then please let me know or we can continue communicating issues via email, whatever works best for you.

bpeacock44 commented 4 months ago

Oh, no, this is great! Then we can indicate areas with problems/etc. I just need to get my head in the github game. Thank you Mario!

mcuaya1 commented 4 months ago

Of course, if you have any questions on github in general or collaborating in github please feel free to reach out. I'll go ahead and close the issue now