bpearson / atom-phpcs

PHP CodeSniffer package for Atom editor
MIT License
6 stars 1 forks source link

Add more info to readme. #14

Closed lukasoppermann closed 8 years ago

lukasoppermann commented 8 years ago

Hey, so I am still a bit confused how it is supposed to work, maybe you could add some screenshots, etc.

I saw that sometimes there is a message at the bottom of the screen. Will lines be marked as well? Maybe you could add an icon (warning and errors) with a count in the bottom bar? Or something like this? And maybe a "all fine" if no errors or warnings are available?

bpearson commented 8 years ago

Will add a screenie or two, but the gutter shows the errors/warning and when you move the cursor over a line with an error/warning, you get the message in the status bar

lukasoppermann commented 8 years ago

Ahha, okay, I also have a git plugin thingy, which does change the gutter as well and is on top of yours, so I actually did not get to see the markings from phpcs. :)

I would still appreciate an (optional) counter in the status bar for people like me who use an interfering git packages.

bpearson commented 8 years ago

Can you post a screenie and which plugin? If I can replicate I will try and address it

lukasoppermann commented 8 years ago

Sure, the package is https://github.com/atom/git-diff

In the screenshot you can see that both classes are on the same element and git wins.

Thanks for looking into it.

screen shot 2015-11-17 at 21 50 11
bpearson commented 8 years ago

Done v1.3.0 but not entirely convinced moving it to the right was the way to go, but it will do for now (I tried having both on the left but red and yellow together was too much)

lukasoppermann commented 8 years ago

Well, I appreciate it, it definitely works. :+1: