bpellin / keepassdroid

KeePass implementation for android
http://www.keepassdroid.com
Other
1.38k stars 346 forks source link

Option delete group #267

Open ghost opened 6 years ago

ghost commented 6 years ago

Please add in app android option to delete group. This option is not available and only in windows app.

rosc2112 commented 6 years ago

Keepass dx can delete groups but its double the size. I'd like to have it in this app which I like more :)

Thanks for the excellent app :)

J-Jamet commented 6 years ago

In the code, adding, updating and deleting must be harmonized and encapsulated to be available for all list items and especially for groups. (I did it by creating a super class "Node" inherited by groups and entities, then managed by a reclyclerview, but not so easy. Then you have to bind the thread removal actions to call methods to delete the group in the database or to move it in recyclerbin if it is activated.)

@rosc2112 I'll try to decrease the size of the application (it comes from the pack of icons material design not yet vectorized). (Can you also tell me why you prefer KeePassdroid? It's a feeling, for design or code?)

rosc2112 commented 6 years ago

I like kpd more just cos its smaller & simpler (old school hater of bloatware since DOS 3.0 :)

I'll always choose the smaller of two otherwise equal programs. Plus only have 1gb of internal mem for apps.

J-Jamet commented 6 years ago

@rosc2112 Thanks for the answer, I take note for the size! ;)