search

bpennypacker / SenseME-Indigo-Plugin

Indigo Plugin for 'Big Ass Solutions' Haiku Fans with SenseME
GNU General Public License v2.0
5 stars 4 forks source link

Initialize coolingIdealTemp and sleepIdealTemp to 0 instead of '' #11

Closed codeskein closed 5 years ago

codeskein commented 5 years ago

This appears to allow the configuration UI to validate when saving a device that was originally created with 0.6.1 (and is missing those fields)

gt3mike commented 5 years ago

I'd love to test this, but I'm very new to GitHub and I can't figure out how to assemble and download an updated plugin package or even just download the updated file itself. Can you point me in the right direction?

bpennypacker commented 5 years ago

@gt3mike I just merged this fix and will be building a point release for it shortly. But in the meantime if you want to apply this locally you can either edit the file plugin.py by hand since it's a simple change or you can just download the latest version of the file and copy it into the plugin directory.

If you're running Indigo 7.2 for example then you'll find this file on your Indigo server in the directory /Library/Application Support/Perceptive Automation/Indigo 7.2/Plugins/SenseME.indigoPlugin/Contents/Server Plugin/. Make a backup copy of that file then copy over the version you downloaded or edit the file by hand then go into Indigo and restart the plugin. That should be all you need to do.

gt3mike commented 5 years ago

I just tested it and it seems to work. I got an error initially (as expected) when I updated the plugin, but I edited the device from the Indigo Client, restarted the plugin, and no more errors.

One odd thing I noticed has to do with fan state: If I select the fan in the Indigo Device List and look at the details at the bottom of the screen, I can see the fan state changing when I start and stop the fan. But the icon in the device list isn't changing. I could swear it used to.

Don't know if this is related or not. Either way it's a very minor issue.

Mike