search

bpennypacker / phad

Pi-Hole Alternate Display
GNU General Public License v3.0
75 stars 8 forks source link

Phad not showing pihole as updated #16

Open ghost opened 4 years ago

ghost commented 4 years ago

Today’s pihole 5.1 update isn’t showing as installed on screen still showing 5.0 as installed versions for web/FTL/pihole

bpennypacker commented 4 years ago

What does the output of pihole -v -f show?

ghost commented 4 years ago

FTL version is v5.1 (Latest: v5.1)

bpennypacker commented 4 years ago

That should be reflected by phad, eventually. The version information is only checked once every 24 hours as it's something that doesn't change very often, and it also queries https://github.com/bpennypacker/phad/releases/latest for checking the latest version of phad itself. I suppose I could change that so that the pihole version is checked more often, like every hour, and github is only checked every 24 hours.

If it's still showing the old version for you and you want to force it to refresh, you can delete the file where phad keeps the version information (what data_file in phad.conf points to, /tmp/pihole.dat by default). If you do that then it should update the version the next time it cycles through fetching all the data from pihole.

ghost commented 4 years ago

Ok in my config it says that file is in ./phad.dat so it’s in install dir not tmp I have removed the .dat file and it’s now correct on screen

bpennypacker commented 4 years ago

Great. I'll definitely look into refactoring the version checks to avoid this sort of confusion in the future.

ghost commented 4 years ago

Great thank you! Appreciate the help