Closed astoycos closed 1 month ago
Attention: Patch coverage is 5.88235%
with 64 lines
in your changes missing coverage. Please review.
Project coverage is 26.74%. Comparing base (
1861e30
) to head (eb369fa
). Report is 13 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
cmd/bpfman-operator/main.go | 0.00% | 33 Missing :warning: |
controllers/bpfman-operator/configmap.go | 11.42% | 30 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hold until I can manually test on OCP, cluster bot is fighting me ATM
Tested on OCP 4.15 👍
is there a need to write specific section in the readme for deploying on OCP cluster ?
It's already there right? https://github.com/bpfman/bpfman-operator#deploy-to-openshift-cluster
Make sure the bundle is installed in the
bpfman
namespace rather than the openshift-bpfman namespace.Update the SCC to be a bit more tight specifically making it run with
runAsUser: type: MustRunAsNonRoot
Fixup some documentation
Make the operator deploy our custom bpfman-restricted SCC if running in OCP