bpfman / bpfman-operator

Kubernetes operator for bpfman
https://bpfman.io
Apache License 2.0
5 stars 5 forks source link

Add app integeration test #23

Closed msherif1234 closed 3 weeks ago

msherif1234 commented 1 month ago

depends on https://github.com/bpfman/bpfman-operator/pull/6 https://github.com/bpfman/bpfman/pull/1154

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.08%. Comparing base (5fc5db8) to head (40f93c8). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== - Coverage 27.10% 27.08% -0.02% ========================================== Files 81 81 Lines 6837 6844 +7 ========================================== + Hits 1853 1854 +1 - Misses 4800 4806 +6 Partials 184 184 ``` | [Flag](https://app.codecov.io/gh/bpfman/bpfman-operator/pull/23/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpfman) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bpfman/bpfman-operator/pull/23/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpfman) | `27.08% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpfman#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anfredette commented 3 weeks ago

I see what's happening. The kprobe, tracepoint and uprobe checks have a log, but the TC and XDP checks don't. However, the other tests also dump the log, so you can still tell that it's functioning when looking at the test log. I think it would be good to have "BPF program is functioning" logs for TC and XDP too.

anfredette commented 3 weeks ago

I have a few minor requests for some log changes, but otherwise, this looks good to me. Thanks!