bpfman / bpfman-operator

Kubernetes operator for bpfman
https://bpfman.io
Apache License 2.0
5 stars 5 forks source link

SDN-5007: introducing bfpapplication object #6

Closed msherif1234 closed 1 month ago

msherif1234 commented 1 month ago

Fix https://github.com/bpfman/bpfman/issues/1142

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 35.62005% with 488 lines in your changes missing coverage. Please review.

Project coverage is 27.10%. Comparing base (eb369fa) to head (5fc5db8). Report is 13 commits behind head on main.

Files Patch % Lines
controllers/bpfman-agent/application-program.go 34.82% 143 Missing and 3 partials :warning:
...nt/clientset/typed/apis/v1alpha1/bpfapplication.go 0.00% 97 Missing :warning:
apis/v1alpha1/zz_generated.deepcopy.go 48.80% 55 Missing and 9 partials :warning:
...et/typed/apis/v1alpha1/fake/fake_bpfapplication.go 0.00% 63 Missing :warning:
...ontrollers/bpfman-operator/application-programs.go 25.92% 38 Missing and 2 partials :warning:
...t/externalversions/apis/v1alpha1/bpfapplication.go 0.00% 21 Missing :warning:
pkg/client/apis/v1alpha1/bpfapplication.go 0.00% 16 Missing :warning:
cmd/bpfman-agent/main.go 0.00% 6 Missing :warning:
cmd/bpfman-operator/main.go 0.00% 6 Missing :warning:
controllers/bpfman-agent/uprobe-program.go 70.58% 4 Missing and 1 partial :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6 +/- ## ========================================== + Coverage 26.74% 27.10% +0.35% ========================================== Files 75 81 +6 Lines 6146 6837 +691 ========================================== + Hits 1644 1853 +209 - Misses 4337 4800 +463 - Partials 165 184 +19 ``` | [Flag](https://app.codecov.io/gh/bpfman/bpfman-operator/pull/6/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpfman) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bpfman/bpfman-operator/pull/6/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpfman) | `27.10% <35.62%> (+0.35%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpfman#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anfredette commented 1 month ago

In general, I think your bpfapplication CRD looks okay. As I said above, I'm going to have to think about how/whether we could use the existing code some more though.

I added a few random thoughts in comments here.

mergify[bot] commented 1 month ago

@msherif1234, this pull request is now in conflict and requires a rebase.

anfredette commented 1 month ago

Rebased on pr #21.

anfredette commented 1 month ago

I fixed some lint errors.

anfredette commented 1 month ago

we may just want to remove the uprobe entry to avoid having to deploy a target

If we change the attach point to the one being used in the uprobe sample, it won't require the target. I was going to make this change at some point.

mergify[bot] commented 1 month ago

@msherif1234, this pull request is now in conflict and requires a rebase.