Closed msherif1234 closed 1 month ago
Attention: Patch coverage is 35.62005%
with 488 lines
in your changes missing coverage. Please review.
Project coverage is 27.10%. Comparing base (
eb369fa
) to head (5fc5db8
). Report is 13 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In general, I think your bpfapplication CRD looks okay. As I said above, I'm going to have to think about how/whether we could use the existing code some more though.
I added a few random thoughts in comments here.
@msherif1234, this pull request is now in conflict and requires a rebase.
Rebased on pr #21.
I fixed some lint errors.
we may just want to remove the uprobe entry to avoid having to deploy a target
If we change the attach point to the one being used in the uprobe sample, it won't require the target. I was going to make this change at some point.
@msherif1234, this pull request is now in conflict and requires a rebase.
Fix https://github.com/bpfman/bpfman/issues/1142