feat(provider): add support for `ssh-agent` on Windows

Sparta142 commented 3 weeks ago

Contributor's Note

[x] I have added / updated documentation in /docs for any user-facing features or additions.
[ ] I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
[x] I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1257

Sparta142 commented 3 weeks ago

One concern I had: ssh-agent on Windows doesn't set the SSH_AUTH_SOCK env, which might be surprising behavior to some users.

A couple of possible solutions: either add a fallback to \\.\pipe\openssh-ssh-agent on Windows like other SSH binaries do, or make a note of this in the docs. Any opinion?

Sparta142 commented 3 weeks ago

@bpg For consistency, I think assuming the socket path (if the user doesn't provide one) is the right behavior. I made a note of this in the documentation.

bpg commented 3 weeks ago

@all-contributors please add @Sparta142 for code

allcontributors[bot] commented 3 weeks ago

@bpg

I've put up a pull request to add @Sparta142! :tada:

bpg / terraform-provider-proxmox