bpg / terraform-provider-proxmox

Terraform Provider for Proxmox
https://registry.terraform.io/providers/bpg/proxmox
Mozilla Public License 2.0
850 stars 138 forks source link

Support `bzip2` decompression algorithm in `pve_download_file` #1513

Closed jmuchovej closed 2 months ago

jmuchovej commented 2 months ago

Is your feature request related to a problem? Please describe. Yes. bzip2 compressed ISOs cannot be downloaded/used to complete the full VM creation pipeline via Terraform. (Here's a link to the OPNSense ISO I was trying to use.)

Describe the solution you'd like Clarity on whether the limitations of decompression_algorithm are imposed by the provider or the Proxmox API? (Perusing the Proxmox API, it seems like the API doesn't impose such limitations? It also appears that Go natively supports bzip2 [de]compression?)

Describe alternatives you've considered There aren't really any? OPNSense only appears to ship bz2 image files and I'm not going to rebuild the provider from scratch just to support this. 😅

I'm happy to contribute, but I'm a Go novice and am unsure where the decompression is handled, based on download_url.go – perhaps Proxmox itself does this?

jmuchovej commented 2 months ago

Ah! I didn't realize that this was actually limited by Proxmox! Feel free to close. CleanShot 2024-08-25 at 16 48 16

bpg commented 2 months ago

Yeah, that's the PVE limitation.