search

bphermansson / EspSparsnasGateway

Reads data from Ikea Sparsnäs energy meter and publish via Mqtt.
MIT License
39 stars 27 forks source link

Update EspSparsnasGateway_schem_Nodemcu.png #27

Closed Naesstrom closed 5 years ago

Naesstrom commented 5 years ago

Updated the schematic with a new one that works.

dogmatic69 commented 5 years ago

I do not believe ground should be connected directly to the antenna. This link has some more info with various ways to hook it up.

https://learn.sparkfun.com/tutorials/rfm69hcw-hookup-guide/the-antenna

Naesstrom commented 5 years ago

Ah thought I removed that, the schematic is for a edge mounted SMA antenna but I'll remove it and reupload a new one. GND shouldn't be connected to rst permanently neither.

dogmatic69 commented 5 years ago

Ground should totally be connected to RST. See: https://github.com/bphermansson/EspSparsnasGateway/issues/20

You could just modify this PR, no need to open a new one.

Naesstrom commented 5 years ago

@dogmatic69 yes but it should only be pulled low when initiating the radio not all the time as I understand it from Adafruits guide?

At the top of the sketch you can also set the pinout. The radios will use hardware SPI, but you can select any pins for RFM69_CS (an output), RFM_IRQ (an input) and RFM_RST (an output). RFM_RST is manually used to reset the radio at the beginning of the sketch. RFM_IRQ must be an interrupt-capable pin. Check your board to determine which pins you can use!

dogmatic69 commented 5 years ago

These additional commits should not be in this PR. You need to make branches for your PR's @Naesstrom

Naesstrom commented 5 years ago

Sorry @dogmatic69 still a beginner at GIT could you give me a pointer what you mean?

dogmatic69 commented 5 years ago

@Naesstrom you have made these changes on master branch and now made additional changes which are showing up here. The only changes in the PR should be the image.

You need to create a fork from master and modify that PNG. Once done you can push that branch to github and then edit this PR so that it will merge the new branch with only image changes into master.