Add language translations to locale files

bpierre / gtranslate

Translate the selected text using Google Translate.

https://addons.mozilla.org/firefox/addon/gtranslate/

Mozilla Public License 2.0

95 stars 27 forks source link

Add language translations to locale files #80

Closed PerfectSlayer closed 7 years ago

PerfectSlayer commented 8 years ago

Remove language translation from data/languages.json but keep language configurations. Update addon script (index.js) to use I18N API for language translations.

~~This PR is for test only (do not merge). It was not fully tested yet. Thanks.~~

PerfectSlayer commented 8 years ago

Hi everyone,

The PR seems good to me. If anyone could test it and give me feedback, it will be nice before merging it. Thanks.

bpierre commented 7 years ago

I merged this one first, looks good to me, thanks.

I just wonder if we should translate the languages when the rest of the addon is not translated, as it feels a bit weird to read a sentence mixing two languages like: “Change language (Français > Anglais)”.