search

bpierre / gtranslate

Translate the selected text using Google Translate.
https://addons.mozilla.org/firefox/addon/gtranslate/
Mozilla Public License 2.0
95 stars 27 forks source link

Check Firefox e10s compability #81

Closed SemenMartynov closed 7 years ago

SemenMartynov commented 8 years ago

Hi! Can you check and confirm, that gtranslate is fully compatible with Firefox Electrolysis? On http://arewee10syet.com/ there is status unknown near the gtranslate.

SemenMartynov commented 8 years ago

When gtranslate enabled, my system (Arch Linux && FF49.0) shows Multiprocess Windows: 0/1 (Disabled by add-ons), but when I disable it, multiprocess stats to work...

S3ndG commented 8 years ago

With FF 49, only a few while-listed add-ons work with e10s. If you want to use gtranslate with e10sand ff 49, you can force e10s : https://wiki.mozilla.org/Electrolysis#Force_Enable or you can wait for future release of firefox :)

SemenMartynov commented 8 years ago

So, there is no need to aspire to get into this list?

S3ndG commented 8 years ago

Please read this part of the wiki : https://wiki.mozilla.org/Electrolysis#Add-ons_Schedule

SemenMartynov commented 8 years ago

OK, thank you!

PerfectSlayer commented 8 years ago

I reopened the issue as its remark is good. As you can see, the addon description does not provide information about e10s compatibility.

If the addon supports it, it should request the following permission:

multiprocess: true

as documented here. We need to test it, then mark it if supported. Otherwise, we need to upgrade it for e10s support.

Thanks @SemenMartynov

PerfectSlayer commented 8 years ago

I confirm the addon is not electrolysis compatible for now.

Here is a preview when addon is now running in compatibility mode: gtranslate-e10s As you can see, it's broken… 😞

My best guest is we should use the context menu API to handle menu creation and edition but I would like end PR #80 before creating new code conflicts. The issue #66 could also fix this kind of issue.

S3ndG commented 8 years ago

On my computer, with FF 49.0.1 and e10s enabled, gtranslate works well. The only problem I have with it is a more longer start-up of firefox...

PerfectSlayer commented 8 years ago

@S3ndG If an addon doesn't declare it is compatible with e10s, it will work in a compatibility mode. So it won't be blocked at startup and keeps working as expected but with poor performance.

S3ndG commented 8 years ago

Hello, how do you declare that gtranslate is compatible with e10s? It would be great if it doesn't work in a compatibility mode, for better performance :)

PerfectSlayer commented 7 years ago

Hi @S3ndG Look at the link I post when I reopen the issue about addon description. All documentation is here :wink:

S3ndG commented 7 years ago

Hi :) It would be great if gtranslate would be marked compatible with e10s for the release of FF 50, I could have multi-process enabled by default : https://wiki.mozilla.org/Electrolysis#Add-ons_Schedule All the webextensions should work with FF 50 too.

S3ndG commented 7 years ago

Hello, I have opened package.json with notepad and I notice this : "permissions": { "private-browsing": true },

Could you tell me how can I add "multiprocess": true to the permissions? thanks :)

bpierre commented 7 years ago

@PerfectSlayer It works for me with the shim disabled. Maybe something else has changed since when you tried it?

Closing for now https://github.com/bpierre/gtranslate/commit/91f0e265a5f489af4fb28770c9d5adb071ec338c