search

bpierre / gtranslate

Translate the selected text using Google Translate.
https://addons.mozilla.org/firefox/addon/gtranslate/
Mozilla Public License 2.0
95 stars 27 forks source link

Port to webextension #86

Open marczellm opened 6 years ago

marczellm commented 6 years ago

This is a working port to WebExtension. Fixes #66 and #85

I did not write a new Makefile as I'm not familiar with it.

bpierre commented 6 years ago

Thanks for this effort @marczellm, and I apologise for not being as active as I’d like to be on this project. I’ll have a look whenever possible in the next week.

PerfectSlayer commented 6 years ago

Nice @marczellm 👍 💖

I understand your concern but I am like you! I spent hours to fix some issues and maintain this add-on and I got no right to update it on AMO and no privileged contact with @bpierre 😞

The best I can do is test your (awesome) work and merge your PR. But it still won't update the add-on on AMO 😢

Whatever you choose, ping me if you need help with Makefile. It's not so complicated once you learn it 😉

PerfectSlayer commented 6 years ago

@bpierre No worry, it's common in Open Source software that the maintainer became busy or move from a project. But why do not you create a GitHub organization and list other maintainer as "extension developer" on AMO? So we could continue to evolve the add-on without having to fork and loose all the users?

bpierre commented 6 years ago

@PerfectSlayer Sure thing! I didn’t see the release itself as the bottleneck, it’s a quick thing for me to do once we get something merged.

The problem is more to find the time to review PRs, especially this one, which is a rewrite that also contains at least one important UX change. I would like to review it properly before merging it. To be entirely honest, I also felt a bit discouraged when the new Firefox extension format got replaced by a new-new one, and lost some motivation. But I would be super happy to be able to use gtranslate again!

⬇️ Actions ⬇️

@marczellm sorry for polluting this PR 😅

mote0230 commented 6 years ago

As far as I know, without https://bugzilla.mozilla.org/show_bug.cgi?id=1440635 the extension will send your selected text to Google every time you right click and have text selected, which was unacceptable for privacy reasons to most maintainers. Anything changed here?

Op wo 9 mei 2018 18:59 schreef Pierre Bertet notifications@github.com:

@PerfectSlayer https://github.com/PerfectSlayer Sure thing! I didn’t see the release itself as the bottleneck, it’s a quick thing for me to do once we get something merged.

The problem is more to find the time to review PRs, especially this one, which is a rewrite that also contains at least one important UX change. I would like to review it properly before merging it. To be entirely honest, I also felt a bit discouraged when the new Firefox extension format got replaced by a new-new one, and lost some motivation. But I would be super happy to be able to use gtranslate again!

⬇️ Actions ⬇️

  • I think it makes sense to use gtranslate/gtranslate now. I used to think that an organization for a single project was overkill, but it is a common practice on GitHub nowadays. Doing it now.
  • Shall we create a Gitter https://gitter.im channel? We already have an IRC channel but Gitter might be easier to use nowadays.
  • @PerfectSlayer https://github.com/PerfectSlayer I will give you the rights to publish releases on AMO too 👍

@marczellm https://github.com/marczellm sorry for polluting this PR 😅

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bpierre/gtranslate/pull/86#issuecomment-387806075, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtZMQH50OX_f2Q4WSlv6g8oHxke2M0Jks5twyBbgaJpZM4T4nfD .

marczellm commented 6 years ago

No, it hasn’t changed.

achernyakevich-tch commented 6 years ago

Hi.

Maybe desired feature could be achieved by slight change of user behavior. For example, the following case could be valuable for me:

So difference is only "click/press Enter" vs "on mouse over/selection item by keyboard".

From other side it will completely avoid problem of sending of selection to Google every time when context menu is called.