bpkg / bpkg.github.io

Homepage for the bpkg project http://bpkg.sh
14 stars 39 forks source link

Background does not cover full height on long pages #70

Closed Potherca closed 1 year ago

Potherca commented 1 year ago

The latest changes for full-height on smaller content has caused full-height to break on longer content.

This is caused because the height is set to 100% but the page is longer than 100%.

image

Setting the min-height to 100% would fix this for long pages but break for short pages

image

The solution would be to set both height and min-height on the body but only min-height on #page:

body {
    min-height: 100%;
    height: 100%;
}

#page {
    min-height: 100%;
}

I don't have time to fix the code right now, if nobody else picks this up, I'll come back to it later.

samlikins commented 1 year ago

@Potherca, you're absolutely correct, good catch. I didn't notice that issue, the problem didn't seem to show on my local preview for longer pages. Updates have been made.

samlikins commented 1 year ago

PR #71, compared, merged, and closed.

Potherca commented 1 year ago

@samlikins No worries! 👍