Timeline Drawer

[alexandergknoll]

@garrettdashnelson I think we'll likely want to make some tweaks, but this is a good starting point. Two important things I've noticed which are regressions from the existing implementation:

1. I don't think the map ID is in the dataset for the timeline that would be needed to link out to the map
2. I don't think there's an image in the dataset for each map

[netlify[bot]]

✅ Deploy Preview for argo-astro-dev ready!

Name	Link
🔨 Latest commit	b524efafe63699ec349571382679add02ad29874
🔍 Latest deploy log	https://app.netlify.com/sites/argo-astro-dev/deploys/65eb2e772c73df000835a77b
😎 Deploy Preview	https://deploy-preview-88--argo-astro-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[garrettdashnelson]

@alexandergknoll This looks visually great.

Ideally I think that the maps parameter of the openDrawer function should take an array of map identifiers and nothing else. This is actually what is being executed on line 48 where the button indicating maps associated with an event triggers openDrawer(event.solr_ids_array).

The trouble is coming from the other time this function is called, on line 32, where the button is supposed to trigger all the maps associated with a given year. (<a @click="openDrawer(data.timeline_events[parseInt(year)])" class="tooltip">) That's garbage data anyhow, so let's simply remove that element and leave only the "n related maps" button, which should pass correct data?

That way the store drawerMaps can expect to get the array of IDs, and use it to populate a set of mini map cards/list. Does that make sense?

[alexandergknoll]

@garrettdashnelson thanks for your help with that - makes perfect sense! Let me know if I got it a bit closer with these edits

[garrettdashnelson]

This looks great to me! @almontg & @hkemp2128 any feedback? https://deploy-preview-88--argo-astro-dev.netlify.app/

[garrettdashnelson]

@alexandergknoll One minor UI tweak would be to make the "n Results" plus the "X" that closes the drawer sticky, so that when a user scrolls down in the list of resultant maps, they still have an obvious visual clue for closing the drawer.

[hkemp2128]

[almontg]

This looks great! Henry and I just chatted very breifly and both agree that we like the size of the thumbnails and amount of info. My one note here is that it covers up the timeline UI so you can't really browse or read other entries without closing the sidebar, but I'm fine with this for now

[alexandergknoll]

@garrettdashnelson I made that top bar sticky so that it's persistent when scrolling!