resolves issue #30 , eliminates false positive mach

bploetz / versionist

A plugin for versioning Rails based RESTful APIs.

MIT License

971 stars 51 forks source link

resolves issue #30 , eliminates false positive mach #31

Closed gouthamvel closed 11 years ago

gouthamvel commented 11 years ago

orig: "v1.1".include?("v1") => true mod: "v1.1".eql?("v1") => false

orig was causing the wrong version to load. The mod fixes it. Works with Accept header, custom header, defaults.

bploetz commented 11 years ago

This bug has been fixed in the release-1.0 branch. Before merging this to master and releasing version 1.0 with this change, I'd appreciate it if you could test this out with your API and verify that this fixes the issue for you. Change the dependency on versionist in your Gemfile to the following....

gem 'versionist', :git => 'git://github.com/bploetz/versionist.git', :branch => 'release-1.0'

...and run bundle update versionist.

bploetz commented 11 years ago

Versionist 1.0.0 has been released with this change. Let me know if you run into any issues.

gouthamvel commented 11 years ago

sure will do it soon