bploetz / versionist

A plugin for versioning Rails based RESTful APIs.
MIT License
972 stars 51 forks source link

Controllers don't work on Rails 4.1.0 when the 'spring' gem is enabled? #67

Closed adibsaad closed 9 years ago

adibsaad commented 9 years ago

Ran a simple rails g versionist:new_api_version ... on a rails 4.1.0 project with `gem spring' in the Gemfile. It hung until I stopped it and found the trace. Disabling spring worked. Any ideas? Note: I don't really need spring.

bploetz commented 9 years ago

Hmm, I can't reproduce this locally.

[bploetz:~/workspace/versionist-test-apis/test-api-rails41]  bundle list
Gems included by the bundle:
  * actionmailer (4.1.5)
  * actionpack (4.1.5)
  * actionview (4.1.5)
  * activemodel (4.1.5)
  * activerecord (4.1.5)
  * activesupport (4.1.5)
  * arel (5.0.1.20140414130214)
  * builder (3.2.2)
  * bundler (1.6.5)
  * coffee-rails (4.0.1)
  * coffee-script (2.3.0)
  * coffee-script-source (1.7.1)
  * erubis (2.7.0)
  * execjs (2.2.1)
  * file-tail (1.0.12)
  * hike (1.2.3)
  * i18n (0.6.11)
  * jbuilder (2.1.3)
  * jquery-rails (3.1.1)
  * json (1.8.1)
  * mail (2.5.4)
  * mime-types (1.25.1)
  * minitest (5.4.0)
  * multi_json (1.10.1)
  * polyglot (0.3.5)
  * rack (1.5.2)
  * rack-test (0.6.2)
  * rails (4.1.5)
  * railties (4.1.5)
  * rake (10.3.2)
  * rdoc (4.1.1)
  * ruby2ruby (2.1.1)
  * ruby_parser (3.6.2)
  * sass (3.2.19)
  * sass-rails (4.0.3)
  * sdoc (0.4.1)
  * sexp_processor (4.4.4)
  * sourcify (0.5.0)
  * spring (1.1.3)            <--------------------------- Spring
  * sprockets (2.11.0)
  * sprockets-rails (2.1.3)
  * sqlite3 (1.3.9)
  * thor (0.19.1)
  * thread_safe (0.3.4)
  * tilt (1.4.1)
  * tins (0.13.2)
  * treetop (1.4.15)
  * turbolinks (2.3.0)
  * tzinfo (1.2.2)
  * uglifier (2.5.3)
  * versionist (1.3.0)
  * yard (0.8.7.4)

[bploetz:~/workspace/versionist-test-apis/test-api-rails41]  bundle exec rails g versionist:new_api_version v1 V1 --path=value:v1
       route  api_version(:module => "V1", :path => {:value => "v1"}) do
  end
       exist  app/controllers/v1
      create  app/controllers/v1/base_controller.rb
      create  test/functional/v1
      create  test/functional/v1/base_controller_test.rb
      create  test/integration/v1
      create  test/integration/v1/base_controller_test.rb
      create  app/presenters/v1
      create  app/presenters/v1/base_presenter.rb
      create  test/presenters/v1
      create  test/presenters/v1/base_presenter_test.rb
      create  app/helpers/v1
      create  test/helpers/v1
      create  public/docs/v1
      create  public/docs/v1/index.html
      create  public/docs/v1/style.css

What version of Ruby are you running? Can you include the trace you allude to in your report?

bploetz commented 9 years ago

I also tried downgrading to Rails 4.1.0, and it still works for me.

adibsaad commented 9 years ago

Hi Brian,

Thanks for getting back to me. I figured out the problem and it wasn't versionist.

Thanks

bploetz commented 9 years ago

Cool.