search

bploetz / versionist

A plugin for versioning Rails based RESTful APIs.
MIT License
972 stars 51 forks source link

gem dependency #68

Closed sufleR closed 9 years ago

sufleR commented 9 years ago

I noiticed that versionist requires whole rails gem.

It makes poinless using rails-api gem together with versionist.

Is necessary to require whole rails here?

trautwein commented 9 years ago

+1

bploetz commented 9 years ago

No, it shouldn't need all of rails. It should only need active_support, railties, and maybe some other minor things.

Are you guys using rails-api? I can push up a branch which changes the dependencies that you can test with a rails-api app.

sufleR commented 9 years ago

yes I am using versionist with rails-api.

bploetz commented 9 years ago

OK, I pushed up a branch with a fix for this, and it seems to work for both rails and rails-api apps for me locally.

Update your Gemfile to...

gem 'versionist', :git => 'https://github.com/bploetz/versionist.git', :branch => 'dependency_updates'

...then run bundle update versionist and give it a whirl in your app. Let me know how it goes.

sufleR commented 9 years ago

updated and all tests are passing.

Will update you later how it is working on staging.

bploetz commented 9 years ago

@sufleR any update on your testing with this change in staging?

sufleR commented 9 years ago

@bploetz sorry for late reply but I was waiting for staging server.

Right now application is deployed to staging and working without any problems.

bploetz commented 9 years ago

I released versionist 1.4.0 with this change.