Fix generator for Rails 5.0

bploetz / versionist

A plugin for versioning Rails based RESTful APIs.

MIT License

971 stars 51 forks source link

Fix generator for Rails 5.0 #81

Closed ryancheung closed 7 years ago

ryancheung commented 7 years ago

Functional test files in Rails 5.0 are placed in test/controllers folder
Functional test class in Rails 5.0 is inherited from ActionDispatch::IntegrationTest, and also is the integration tests, so integration test template was removed.
Rails 5 has not more Test::Unit::TestCase, use ActiveSupport::TestCase instead.
This fix only include UnitTest part, no chances in Rspec part.

fix https://github.com/bploetz/versionist/issues/80

bploetz commented 7 years ago

@ryancheung thanks for this. The PR as is will break the generators for anyone using versionist with versions of Rails < 5. It looks like we'll need to change the generators such that they inspect the current version of Rails, and if it's < 5 do what it does today, and if it's >= 5 use this new structure. Also, there are specs for the generators that will need to be updated accordingly as well. Let me know if you have time to make these changes. Otherwise, I can use your branch as a base and make the additional changes when I get some time.

ryancheung commented 7 years ago

@bploetz You're right. I'll make these change when i'm available. Thanks!

umar-ahmed commented 7 years ago

@ryancheung @bploetz are either of you still working on this? It would be nice to see these changes made since Rails 5 has been out in the wild for a while now and I would like to make use of the generators in this gem.