Add support for rails 5.x

jaredplanter commented 7 years ago

Why?

To add full support for Rails 5.x including fixing generators and tests.

closes #81
resolves #83

What Changed?

Added Rails 5.1 GemFile
Updated RakeFile
Updated travis configuration
Update gem dependencies for all versions as to make tests pass
Added Versionist.older_than_rails_5? and Versionist.test_path to determine the test path to use since they changed in Rails 5.x
Added older_than_rails_5? andtest_pathtospec_helper` for the same compatibility
Updated all generators to be compatible with Rails 5.x and older
Updated all generator specs to be compatible with Rails 5.x and older
Created *_rails_5.rb files where applicable in controller generation testing
Updated ApiRoutingSpec to exclude a default /foos route that routes to a non-existent FoosController
Updated ApiRoutingSpec to support the new arbitrary argument syntax is active_support 5.x and maintain backwards compatibility
Updated all TestApi controllers to respond to text, json or xml using a respond_to block

Notes

Once all versions are bundled, tests pass using: rake test:all

Please review and let me know if you have any questions.

Thanks!

Jared Planter WeaveUp, Inc.

bploetz commented 7 years ago

@jaredplanter you sir, are my hero. high five

Taking a look at this now......

bploetz commented 7 years ago

(and @chrishough LOL)

chrishough commented 7 years ago

Thank you for creating this @jaredplanter.

@bploetz I think it also closes https://github.com/bploetz/versionist/issues/80

After this goes through I think this will be the leading gem for api versioning on the market, especially with this level of backwards compatibility

bploetz commented 7 years ago

@jaredplanter @chrishough Looks like we also need to update the travis matrix to use ruby 2.2.2 (at least), as the Rails 5.0 and 5.1 tests are failing with:

Gem::InstallError: rack requires Ruby version >= 2.2.2

jaredplanter commented 7 years ago

@bploetz Ah, yes. I forgot to bump the ruby version. Looking into the failing tests now.

bploetz commented 7 years ago

@jaredplanter I pushed up some fixes. Let's see if they fix the problem......

jaredplanter commented 7 years ago

@bploetz Hm, looks like that didn't do it. I'll be back at my computer in a bit to dig into it some more.

bploetz commented 7 years ago

@jaredplanter yeah I'm working on it. This is literally the worst part of this project, the dependency matrix hell among the ruby and rails versions. :)

chrishough commented 7 years ago

@bploetz they all have been adjusted.

chrishough commented 7 years ago

@bploetz do you see anything else that needs to be modified?

jaredplanter commented 7 years ago

@bploetz That makes perfect sense! I'm surprised I didn't catch that. @chrishough Thanks for making the adjustments!

I'm back at my computer now too.

bploetz commented 7 years ago

versionist 1.6.0 has been released with these changes.

Thanks again @jaredplanter and @chrishough

jaredplanter commented 7 years ago

Thanks for settling the dependencies @bploetz!

chrishough commented 7 years ago

Hooray! This is great news.

bploetz / versionist