bploetz / versionist

A plugin for versioning Rails based RESTful APIs.
MIT License
972 stars 51 forks source link

Tests error on rails 5.2.1 #87

Open alee-ccu opened 5 years ago

alee-ccu commented 5 years ago

Tests failed on rails 5.2.1:

Failures:
  1) Versionist::CopyApiVersionGenerator v1 => V1 api version exists test_framework: test_unit should copy old controller tests to new controller tests
     Failure/Error:
       parser.enumerator.first.traverse do |node|
         existing_routes = node.source if node.type == :fcall && node.source =~ /api_version.*:?module\s*(=>|:)\s*("|')#{module_name_for_route(old_module_name)}("|')/
       end

     NoMethodError:
       undefined method `enumerator' for true:TrueClass
       Did you mean?  enum_for
     # ./lib/generators/versionist/copy_api_version/copy_api_version_generator.rb:25:in `block in copy_routes'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/actions.rb:198:in `block in in_root'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/actions.rb:188:in `block in inside'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/actions.rb:188:in `inside'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/actions.rb:198:in `in_root'
     # ./lib/generators/versionist/copy_api_version/copy_api_version_generator.rb:18:in `copy_routes'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `block in invoke_all'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `each'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `map'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `invoke_all'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/group.rb:232:in `dispatch'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/railties-5.2.1/lib/rails/generators/testing/behaviour.rb:70:in `block in run_generator'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.1/lib/active_support/testing/stream.rb:33:in `capture'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/railties-5.2.1/lib/rails/generators/testing/behaviour.rb:68:in `run_generator'
     # /home/travis/.rvm/gems/ruby-2.4.1/gems/generator_spec-0.9.4/lib/generator_spec/test_case.rb:37:in `method_missing'
     # ./spec/generators/copy_api_version_generator_spec.rb:271:in `block (6 levels) in <top (required)>'

Full log: https://travis-ci.org/alee-ccu/versionist/jobs/458655944

bploetz commented 5 years ago

Hmm, looks like something may have broken in Yard (which the generators use internally). Will take a look.