search

bpmn-io / actions

The custom github actions used by the bpmn-io team
Other
0 stars 5 forks source link

feat: weeks interval in weekly-notes #16

Closed aabouzaid closed 5 months ago

aabouzaid commented 5 months ago

Hi team :wave:

The Camunda Distro team is using the weekly-notes action but our team meeting is fortnightly (every 2 weeks).

So this PR supports setting the week interval so we can set the jump in the issue title. It's still 1 by default so no behavior change, but if the user sets week-interval: 2 and the flow runs today (year week 21) the title will be W23 - 2024 instead of W22 - 2024.

nikku commented 5 months ago

CC @aabouzaid - https://github.com/bpmn-io/actions/pull/17. Broke non week-interval workflows.

nikku commented 5 months ago

@aabouzaid There is a lot of different things broken about your contribution. The type: number is not a thing in action inputs; hence the variable MUST be cast to a number manually.

I kindly ask you to test out if the action works for you in a real E2E test next time to you contribute it. :slightly_smiling_face:.

nikku commented 5 months ago

Cf. https://github.com/bpmn-io/actions/pull/20 with hopefully the last fix :tm:

aabouzaid commented 5 months ago

@nikku thanks for the info, looks like I mixed the workflow input with action input. Do we have any plans to make some tests to ensure that such changes don't pass to the main branch? I'd be happy to help with that :raised_hands:

nikku commented 5 months ago

@aabouzaid This repo now has code style checking and basic test coverage.

You're more then welcome to expand the existing test coverage along with any future contribution.