Closed aabouzaid closed 5 months ago
CC @aabouzaid - https://github.com/bpmn-io/actions/pull/17. Broke non week-interval
workflows.
@aabouzaid There is a lot of different things broken about your contribution. The type: number
is not a thing in action inputs; hence the variable MUST be cast to a number manually.
I kindly ask you to test out if the action works for you in a real E2E test next time to you contribute it. :slightly_smiling_face:.
Cf. https://github.com/bpmn-io/actions/pull/20 with hopefully the last fix :tm:
@nikku thanks for the info, looks like I mixed the workflow input with action input. Do we have any plans to make some tests to ensure that such changes don't pass to the main branch? I'd be happy to help with that :raised_hands:
@aabouzaid This repo now has code style checking and basic test coverage.
You're more then welcome to expand the existing test coverage along with any future contribution.
Hi team :wave:
The Camunda Distro team is using the
weekly-notes
action but our team meeting is fortnightly (every 2 weeks).So this PR supports setting the week interval so we can set the jump in the issue title. It's still 1 by default so no behavior change, but if the user sets
week-interval: 2
and the flow runs today (year week 21) the title will beW23 - 2024
instead ofW22 - 2024
.