search

bpmn-io / actions

The custom github actions used by the bpmn-io team
Other
0 stars 5 forks source link

fix: Fix week interval #17

Closed vsgoulart closed 3 months ago

vsgoulart commented 3 months ago

https://github.com/bpmn-io/actions/pull/16 broke the action (see this run in the HTO repo)

This was happening because weekInterval was out of the scope of getIssueTitle

barmac commented 3 months ago

I wonder how this was not caught by the CI, and then discovered that there's no CI in this repo 🙈

barmac commented 3 months ago

@vsgoulart please consider rebasing your work on top of https://github.com/bpmn-io/actions/pull/18 to have CI check the code.

vsgoulart commented 3 months ago

@barmac Done, I also fixed an unrelated lint error

nikku commented 3 months ago

@vsgoulart Please cross check my follow-up changes: https://github.com/vsgoulart/actions/commit/78bf72be47aadddbf2ac2a0a2db84e5ed1e29981, https://github.com/bpmn-io/actions/pull/17/commits/4e0d3fce10fc556e918d1667c6dc814fa226e0da.

nikku commented 3 months ago

Merged to main. Tests added via https://github.com/bpmn-io/actions/commit/f6f66e5a4f1f8d583279931bc4ea7a19ee559720 :heavy_check_mark:

nikku commented 3 months ago

Works (no error) https://github.com/bpmn-io/internal-docs/actions/runs/9273489136/job/25542626675

May require additional fine tuning (computed 2025 as a year) - https://github.com/bpmn-io/internal-docs/issues/973#event-12968312127

vsgoulart commented 3 months ago

@nikku Something went wrong for us :see_no_evil:

It should have been W23

image

nikku commented 3 months ago

I'm investigating :dancers:

nikku commented 3 months ago

https://github.com/bpmn-io/actions/pull/16#issuecomment-2136935687

nikku commented 3 months ago

Should be fixed via https://github.com/bpmn-io/actions/pull/20.