fix: extra spaces after element

bpmn-io / bpmn-auto-layout

Layout BPMN diagrams, generating missing DI information.

https://bpmn-io.github.io/bpmn-auto-layout/

50 stars 41 forks source link

fix: extra spaces after element #55

Closed abdul99ahad closed 1 month ago

abdul99ahad commented 2 months ago

Closes #47

Proposed Changes

[x] No extra spaces after element

### Checklist To ensure you provided everything we need to look at your PR: * [x] **Brief textual description** of the changes present * [ ] **Visual demo** attached * [ ] **Steps to try out** present, i.e. [using the `@bpmn-io/sr` tool](https://github.com/bpmn-io/sr) * [x] Related issue linked via `Closes {LINK_TO_ISSUE}` or `Related to {LINK_TO_ISSUE}`

nikku commented 1 month ago

Let's ensure this fix is accompanied by a test case.

philippfromme commented 1 month ago

What is the state of this PR @abdul99ahad? Is it ready for another review?

abdul99ahad commented 1 month ago

What is the state of this PR @abdul99ahad? Is it ready for another review?

Not yet. Waiting for https://github.com/bpmn-io/bpmn-auto-layout/pull/59 approval.

philippfromme commented 1 month ago

Does this PR really depend on https://github.com/bpmn-io/bpmn-auto-layout/pull/59? @abdul99ahad It looks like we could merge this independently.

abdul99ahad commented 1 month ago

Does this PR really depend on #59? @abdul99ahad It looks like we could merge this independently.

I think it's a good idea to wait for the resolution of big PR and then merge this one to avoid any further layout issues this may cause.

philippfromme commented 1 month ago

@abdul99ahad Let's get this ready for a review. Rebase on main and consider adding new snapshot tests.

abdul99ahad commented 1 month ago

Ready for review. No extra spaces after boundary event task.

Before:

After: