Closed philippfromme closed 2 months ago
Let's get this incorporated soonish, in order to test the other open PRs.
I'll get this PR ready.
@philippfromme looks that we need to make sure our snapshots are initially valid.
@barmac Thought I'd done that 🙈
Some of the test cases are not showing in the left panel.
Some of the test cases are not showing in the left panel.
This is because the original diagram doesn't contain any graphical information. While the use case of the library is to create missing graphical information for the snapshot tests it's actually more convinient to have a diagram with graphical information. The library will then simply replace that. I'll update the diagrams that have no DI.
I updated the diagrams without DI and also added an error indication if the import fails completely. Should be clearer now.
Ready for review.
Ready for review.
Looks good to me 🚀
Updated with a minor hint regarding test updates:
Proposed Changes
Allows us to easily compare before and after for the defined test cases. Could be added to the CI so the CI only passes once all snapshots pass meaning you either haven't changed the algorithm or you did and you updated the snapshots.
npm test
and a snapshot that is not matching will result in an unsuccessful test run