bpmn-io / bpmn-js-create-append-anything

A create/append anything bpmn-js extension.
MIT License
9 stars 2 forks source link

Non-interrupting start events missing in create anything list #4

Open nikku opened 1 year ago

nikku commented 1 year ago

Describe the Bug

As a user I want to create a non interrupting message start event in an event sub-process, but I cannot find it.

image

Steps to Reproduce

  1. Trigger create menu
  2. Search for non
  3. Non interrupting start events do not appear in the list

Expected Behavior

Non interrupting start events appear once searched for. I don't think it is strictly necessary to show them all the time.

Environment

nikku commented 1 year ago

CC @smbea

barmac commented 1 year ago

There is a hard-coded check which removes Participants and Start Events from append menu.

nikku commented 1 year ago

Instead of doing that we could hide them initially (rank=-1). We also allow "appending" of event sub-processes.

However this issue specifically is about the create menu, where these entries are not available, too.

smbea commented 1 year ago

Yes the non interrupting start event is missing completely from the options list

smbea commented 1 year ago

I started looking at this. All the non-interrupting start events are missing.

With the current rules, these events are changed into default start events when not placed in an event sub process:

https://user-images.githubusercontent.com/25825387/219695027-54beb9b3-8c46-4ee1-aa9a-59a6e2f76ccd.mov

In my opinion, I think it makes sense to instead block the shape placement like we do for the non-interrupting boundary events. Demo:

https://user-images.githubusercontent.com/25825387/219694934-9b045ed0-7ba5-480a-baab-ec0995df5a13.mov

Wdyt?