When a template is removed, documentation and other non-templated properties are gone

bpmn-io / bpmn-js-element-templates

The element template extension for bpmn-js

MIT License

5 stars 3 forks source link

When a template is removed, documentation and other non-templated properties are gone #114

Open barmac opened 2 months ago

barmac commented 2 months ago

Describe the Bug

When I remove a template, the documentation is gone. The same applies to multi-instance configuration, and upcoming execution listeners.

https://github.com/user-attachments/assets/26708dd9-5634-4a59-b470-6666ea4ca4c7

Steps to Reproduce

Add documentation
Remove template
now this happens

Expected Behavior

Properties are kept.

Environment

Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
OS: [e.g. Windows 7]
Library version: [e.g. 2.0.0]

nikku commented 1 week ago

@barmac I assume the rational for your expected behavior is: The fields you mentioned are not governed by the element template, hence they must not be "fiddled with" as the template is removed. Can you confirm?

barmac commented 1 week ago

Correct! The documentation, ELs, and multi-instance characteristics can be changed and live independently from the template, so they should not be removed with the template removal. For example, if I send a notification to multiple employees, I should not need to reconfigure multi-instance when I change from Slack to email:

https://github.com/user-attachments/assets/19b1bf3f-2f1d-47f9-8707-f0617f31bf02

barmac commented 1 week ago

So it's a bit like we don't make a boundary event interrupting when a template is removed from a non-interrupting boundary event:

https://github.com/user-attachments/assets/b23ea12a-fa4d-4b51-9263-888970e09bf1